Code Reviewer

When to Apply

• Reviewing pull requests
• Performing security audits
• Checking code quality
• Identifying performance bottlenecks
• Ensuring best practices
• Pre-deployment code review

How to Use This Skill

rules/

Quick Start

1. Review AGENTS.md for a complete compilation of all rules with examples
2. Reference specific rules from

   rules/

   directory for deep dives
3. Follow priority order: Security → Performance → Correctness → Maintainability

Available Rules

• SQL Injection Prevention
• XSS Prevention

• Avoid N+1 Query Problem

• Proper Error Handling

• Use Meaningful Variable Names
• Add Type Hints

Review Process

1. Security First (CRITICAL)

• SQL injection
• XSS (Cross-Site Scripting)
• Authentication/authorization bypasses
• Hardcoded secrets
• Insecure dependencies

2. Performance (HIGH)

• N+1 database queries
• Missing indexes
• Inefficient algorithms
• Memory leaks
• Unnecessary API calls

3. Correctness (HIGH)

• Error handling gaps
• Race conditions
• Off-by-one errors
• Null/undefined handling
• Input validation

4. Maintainability (MEDIUM)

• Clear naming
• Type safety
• DRY principle
• Single responsibility
• Documentation

5. Testing

• Unit tests for new code
• Edge case testing
• Error path testing
• Integration tests where needed

Review Output Format

This function retrieves user data but has critical security and reliability issues.

## Critical Issues 🔴

1. **SQL Injection Vulnerability** (Line 2)
   - **Problem:** User input directly interpolated into SQL query
   - **Impact:** Attackers can execute arbitrary SQL commands
   - **Fix:** Use parameterized queries
   ```python
   query = "SELECT * FROM users WHERE id = ?"
   result = db.execute(query, (user_id,))

High Priority 🟠

1. No Error Handling (Line 3-4)
   • Problem: Assumes result always has data
   • Impact: IndexError if user doesn't exist
   • Fix: Check result before accessing
   python

   if not result:
       return None
   return result[0]

2. Missing Type Hints (Line 1)
   • Problem: No type annotations
   • Impact: Reduces code clarity and IDE support
   • Fix: Add type hints
   python

   def get_user(user_id: int) -> Optional[Dict[str, Any]]:

Recommendations

• Add logging for debugging
• Consider using an ORM to prevent SQL injection
• Add input validation for user_id