app-intents-code-review

Original：🇺🇸 English

Translated

Reviews App Intents code for intent structure, entities, shortcuts, and parameters. Use when reviewing code with import AppIntents, @AppIntent, AppEntity, AppShortcutsProvider, or @Parameter.

2installs

Sourceexistential-birds/beagle

Added on2026-02-04

NPX Install

npx skill4agent add existential-birds/beagle app-intents-code-review

SKILL.md Content

View Translation Comparison →

App Intents Code Review

Quick Reference

Issue Type	Reference
AppIntent protocol, perform(), return types	references/intent-structure.md
AppEntity, EntityQuery, identifiers	references/entities.md
AppShortcutsProvider, phrases, discovery	references/shortcuts.md
@Parameter, validation, dynamic options	references/parameters.md

Review Checklist

```
perform()
```
marked with
```
@MainActor
```
if accessing UI/main thread resources
```
perform()
```
completes within 30-second timeout (no heavy downloads/processing)

Custom errors conform to

CustomLocalizedStringResourceConvertible

```
EntityQuery.entities(for:)
```
handles missing identifiers gracefully
```
EntityStringQuery
```
used if Siri voice input needed (not plain
```
EntityQuery
```
)
```
suggestedEntities()
```
returns reasonable defaults for disambiguation
```
AppShortcut
```
phrases include
```
.applicationName
```
parameter
Non-optional
```
@Parameter
```
has sensible defaults or uses
```
requestValue()
```
```
@IntentParameterDependency
```
not used on iOS 16 targets (crashes)
Phrases localized in
```
AppShortcuts.strings
```
, not
```
Localizable.strings
```
App Intents defined in app bundle, not Swift Package (pre-iOS 17)
```
isDiscoverable = false
```
for internal/widget-only intents

When to Load References

AppIntent protocol implementation -> intent-structure.md
Entity queries, identifiers, Spotlight -> entities.md
App Shortcuts, phrases, discovery -> shortcuts.md
Parameter validation, dynamic options -> parameters.md

Review Questions

Does
```
perform()
```
handle timeout limits for long-running operations?
Are entity queries self-contained (no
```
@Dependency
```
injection in Siri context)?
Do phrases read naturally and include the app name?
Are SwiftData models passed by
```
persistentModelID
```
, not directly?
Would migrating from SiriKit break existing user shortcuts?