Loading...
Loading...
Coordinator workflow for orchestrating dockeragents through fix-review-iterate-present loop. Use when delegating any task that produces code changes. Ensures agents achieve 10/10 quality before presenting to human.
npx skill4agent add cygnusfear/agent-skills 4-step-program┌─────────────────────────────────────────────────────┐
│ │
│ ┌──────────┐ ┌──────────┐ ┌──────────────┐ │
│ │ 1. FIX │───►│ 2. REVIEW│───►│ 3. 10/10? │ │
│ │ (agent) │ │ (agent) │ │ (you check) │ │
│ └──────────┘ └──────────┘ └──────┬───────┘ │
│ ▲ │ │
│ │ │ │
│ │ NO │ YES │
│ └─────────────────────────────────┤ │
│ ▼ │
│ ┌──────────────┐ │
│ │ 4. PRESENT │ │
│ │ (you + URLs) │ │
│ └──────────────┘ │
│ │
└─────────────────────────────────────────────────────┘assign_task(agent_id, task_description)Skill(code-reviewer)gh issue view <number>"Fix the authentication bug in(Issue #45).src/auth.tsRequirements from issue (ALL must be implemented):
- Session token expires correctly after 24 hours
- Refresh token works when session token expires
- Error message shown when both tokens expire
- User redirected to login page on auth failure
Success: ALL 4 requirements implemented, tests pass, bug no longer reproducible.When complete, runon your changes, POST the review to GitHub, and report the results with the PR link."Skill(code-reviewer)
Closes #XFixes #Xgh pr view --json closingIssuesReferences## Related Issues
- Closes #45 - Auth token expiration bug
- Related to #40 - Auth system improvementsSkill(code-reviewer)mcp__github__create_pull_request_review"After reviewing, POST your review to GitHub. The human must be able to see your review on the PR page."
gh issue view <number>send_message_to_agent(agent_id, "Review shows X suggestions. Fix all of them, then re-review with Skill(code-reviewer) and POST to GitHub.")# Get ALL checklist items from issue
gh issue view <number> --json body --jq '.body' | grep -E "^\- \["
# Also check for requirements in prose (not just checkboxes)
gh issue view <number>## Issue #X - Full Requirements Check
| Requirement | PR Status | Evidence |
|-------------|-----------|----------|
| [exact text from issue] | ✅ | `file.ts:line` - [implementation] |
| [exact text from issue] | ❌ MISSING | Not found in PR |
| [exact text from issue] | ⚠️ PARTIAL | `file.ts:line` - [what's missing] |
| [exact text from issue] | ⚠️ MANUAL | Requires [runtime/editor] |Implemented (✅ only) / Total Requirements = Coverage %**Honest Assessment**:
- Coverage: X% (Y of Z requirements fully implemented)
- Missing: [list]
- Partial: [list with gaps]
- Manual: [list items needing runtime/editor]| Coverage | Action |
|---|---|
| 100% | ✅ Proceed to Step 4 (Present) |
| < 100% | ❌ DO NOT PRESENT - Loop back to Step 1 |
send_message_to_agent(agent_id, "FINAL COVERAGE CHECK FAILED.
Issue #X - Full Requirements Check:
| Requirement | Status | Evidence |
|-------------|--------|----------|
| [requirement 1] | ✅ | file.ts:45 |
| [requirement 2] | ❌ MISSING | Not in PR |
| [requirement 3] | ⚠️ PARTIAL | Missing X |
Honest Assessment:
- Coverage: W% (Z of Y requirements)
- Missing: [requirement 2]
- Partial: [requirement 3] - needs X
Implement ALL items marked ❌ or ⚠️, then re-review with Skill(code-reviewer) and POST to GitHub.
Do not return until 100% coverage achieved.")[PR #243](https://github.com/owner/repo/pull/243) is ready for review. Resolves [Issue #100](https://github.com/owner/repo/issues/100).PR #243 is ready for review. Resolves Issue #100.PR #42Issue #100| Anti-Pattern | Why It's Wrong |
|---|---|
| Accepting incomplete issue coverage | Issue had 10 requirements, only 8 implemented = NOT DONE. Send back. |
| Accepting "mostly done" | Not 10/10 = not done. Send back. |
| Skipping PR before review | We need a PR BEFORE review. |
| Skipping review step | Every task gets reviewed. No exceptions. |
| Reviewing code yourself | You coordinate. Agent reviews with skill. |
| Bare PR/issue numbers | URLs are mandatory. Always link. |
| Presenting before 10/10 | Loop isn't done. Keep iterating. |
| Review not posted to GitHub | TASK FAILS. Human can't see local-only reviews. Must be on PR page. |
| Accepting completion without GitHub post | Send agent back. Review isn't done until posted. |
EXECUTIVE SUMMARY: ANY SCORE BELOW 10/10 → DO NOT APPROVE, DO NOT PRESENT EXECUTIVE SUMMARY: ANY COVERAGE BELOW 100% → DO NOT APPROVE, DO NOT PRESENT
❌ WRONG:
"Issue #45 requested 5 features. Agent implemented 4 of them.
Review is 10/10. Ready to present!"
"The main bug is fixed. The edge case mentioned in the issue
can be handled in a follow-up. Presenting to human."
"Agent addressed the core requirements. Minor items from the
issue can be done later."
✅ CORRECT:
"Issue #45 has 5 requirements. Agent implemented 4.
Missing: Requirement 5 (handle timeout errors).
Sending agent back: 'Implement requirement 5 from issue #45 -
handle timeout errors as specified in the acceptance criteria.'"
"Review shows 10/10 quality BUT issue coverage is only 80%.
NOT presenting until 100% of issue requirements are implemented."❌ WRONG:
"CI is green and all tests pass. Ready to merge!"
"Build successful, linting passed. Good to go!"
✅ CORRECT:
"CI passes. Now awaiting 10/10 review with all suggestions fixed before presenting to human."❌ WRONG:
"Review: 82/100. Overall solid implementation. APPROVED."
"Review score: 9/10. Verdict: Ready to merge."
"Great work! 95/100, approved with minor notes."
✅ CORRECT:
"Review: 82/100. NOT APPROVED. Agent must fix all 18 points before re-review."
"Review: 9/10. NOT APPROVED. Loop back to Step 1 until 10/10."❌ WRONG:
"Agent completed the work but needs push access to main."
"Changes ready, please cherry-pick commit abc123 to main."
"Work done locally, someone needs to push it."
✅ CORRECT:
"Agent creates branch → Agent creates PR → Review posted as PR comment → 10/10 achieved → Present PR link to human"❌ WRONG:
"Good news! Everything is already done! See PR #243 and #244."
"Fixed in PR #100, related to issue #50."
"All tasks complete - check PRs #10, #11, #12."
✅ CORRECT:
"All tasks complete:
- [PR #243](https://github.com/owner/repo/pull/243) - Auth fix
- [PR #244](https://github.com/owner/repo/pull/244) - Test coverage
Related: [Issue #50](https://github.com/owner/repo/issues/50)"[PR #N](full-url)❌ WRONG:
"Open items:
- #535 Nix CI implementation (orphan spacetime branch)
- #102 Database migration pending
- Issue #88 still needs review"
✅ CORRECT:
"Open items:
- [#535](https://github.com/owner/repo/issues/535) - Nix CI implementation (orphan spacetime branch)
- [#102](https://github.com/owner/repo/issues/102) - Database migration pending
- [Issue #88](https://github.com/owner/repo/issues/88) - Still needs review"| Change Type | Diagram Recommendation |
|---|---|
| Bug fix with flow change | |
| New API endpoint | |
| State handling change | |
| Component refactor | |
## Review Summary
The token refresh implementation correctly handles expiration.
### New Flow
```mermaid
sequenceDiagram
Client->>Server: Request (expired token)
Server-->>Client: 401
Client->>Server: POST /refresh
Server-->>Client: New token
Client->>Server: Retry request
Server-->>Client: 200 Success
```
**Score: 10/10** - All requirements met, clean implementation.1. DELEGATE → assign_task with ALL issue requirements + review + GitHub posting instruction
2. WAIT → Agent fixes + runs Skill(code-reviewer) + POSTS to GitHub
3. CHECK → TWO gates must pass:
GATE 1: Is 100% of issue/task requirements implemented?
NO → send_message_to_agent with missing requirements, go to 2
GATE 2: Is report 10/10 with ZERO suggestions? Is review on PR page?
NO → send_message_to_agent, go to 2
YES → go to 3.5
3.5 FINAL GATE → Re-verify 100% coverage one last time before presenting
NO (< 100%) → send_message_to_agent, go to 1
YES (100%) → go to 4
4. PRESENT → Tell human + CONFIRM 100% coverage + LINK the PR URL + Mermaid diagrams (if complex)15.04tk