Loading...
Loading...
Guidance for receiving and responding to code review feedback. Use when addressing PR review comments, incorporating reviewer suggestions, or managing review discussions.
npx skill4agent add scando1993/sugar respond-reviewEVERY REVIEW COMMENT DESERVES A RESPONSE| Category | Description | Action |
|---|---|---|
| Must-fix | Bugs, security issues, correctness problems, failing tests | Fix immediately, no discussion needed |
| Should-fix | Design improvements, better patterns, readability gains | Fix unless you have a strong reason not to, then explain |
| Discussion | Architectural questions, alternative approaches, trade-offs | Respond with your reasoning, be open to changing your mind |
| Nit | Style preferences, minor naming suggestions, formatting | Fix if easy, acknowledge if not, never argue |
| Thought | Reality |
|---|---|
| "The reviewer doesn't understand my code" | If the reviewer doesn't understand it, the code isn't clear enough. Improve it. |
| "This nit isn't worth fixing" | Nits take 30 seconds to fix and build goodwill. Just fix it. |
| "I'll address these comments in a follow-up PR" | Address them now. Follow-up PRs for review feedback rarely happen. |
| "The reviewer is wrong about this" | Assume good intent. Explain your reasoning, but be genuinely open to being wrong. |