Code Reviewer

Deep constructive review vs project rules + acceptance criteria.

Caller contract (workflow callers)

Invoker:

ns-coder

ns-autonomous

ns-execution-gitlab-issue

(direct or harness reviewer-agent
):

Caller must run this skill — MUST dispatch
```
reviewer-agent
```
when available (
```
../../ns-harness/references/subagent-dispatch.md
```
); else read this
```
SKILL.md
```
in-session. No Cursor Task personas (
```
senior-tech-lead-reviewer
```
,
```
bugbot
```
,
```
security-review
```
) or improvised review.
Gate rules:
```
references/review-gate-workflow.md
```
.
Every response to workflow caller must end exact line:
```
Code Review: {Approved|Rejected|Blocked}
```
. Overall score in Executive Summary.

Session boot

See

../../ns-harness/references/session-boot.md

. Complete Session boot (blocking) before any other step — cold start this reviewer run; mid-session skip only if steps 1–6 done and files unchanged. Never tool-Read

AGENTS.md

Workflow

Session boot — Cold start
```
reviewer-agent
```
/ this skill: Session boot steps 1–6 in
```
session-boot.md
```
. Already booted same agent run (1–6 done), files unchanged: no re-read. Still judge diff vs
```
AGENTS.md
```
(in context) + project rules.
```
git diff
```
(
```
git status
```
if needed).
Focus modified files + surrounding context.
Start immediately — no permission ask.

Ad-hoc diff mode (from

ns-coder

)

Invoker passes working-tree diff only (no

ISSUE_URL

, no version-closure path):

Review
```
git diff
```
on working tree.
Apply Score gate + severity below.

Last line to parent:

Code Review: {Approved|Rejected|Blocked}

Version closure

Apply Score gate; end chat with

Code Review: {Approved|Rejected|Blocked}

Do not write
```
code-review-report.md
```
(or any persistent review report).
```
Rejected
```
/
```
Blocked
```
: minimal fix map in response (
```
references/review-fix-map.template.md
```
) — data another agent needs. No human prose, no positive findings, no history.
```
Approved
```
: Executive Summary + score + verdict line only (no fix map).

Issue review mode

Invoker passes

ISSUE_URL

(or

project_id

issue_iid

Delegate issue context to
```
ns-execution-gitlab-issue
```
context flow or
```
gitlab-issue-context-agent
```
— no
```
read_issue
```
if synthesis block provided.
Diff
```
origin/<target>...origin/<source>
```
from synthesis — never wrong branch.
Requirement proof gate: every AC needs behavioral evidence; producer-only code without consumer = Critical.
Verdict (exactly one):
```
Approved
```
|
```
Rejected
```
|
```
Blocked
```
— Score gate below.

Post internal GitLab comment via

mcp-gitlab-usage

— first line:

Code Review | YYYY-MM-DD HH:MM (UTC) | Verdict: {Approved|Rejected|Blocked}

Last line to parent:

Code Review: {Approved|Rejected|Blocked}

```
Rejected
```
/
```
Blocked
```
: GitLab comment = same minimal fix-map facts.

Score gate (all modes)

Every review must include overall score 1–10. Callers treat hard pass bar.

Score	Meaning	Verdict impact
10	Ideal — ship as-is	Eligible for `Approved`
9	Minimum pass	Eligible for `Approved`
≤8	Below bar	Must be `Rejected` (even zero Criticals)

Approved
only when all true:

Zero Critical findings
Overall score ≥ 9/10 (target 10/10)
Issue review mode: every AC PASS with behavioral evidence

Rejected
when: any Critical, or score ≤ 8, or (Issue mode) any AC fails behavioral proof.

Scoring unit

Score quality of touched module/file after diff, not hunk-alone correctness. Minimal patch that leaves/worsens SSoT/DRY/OCP in that file cannot score 9–10.

Score caps (lowest that fits)

Condition in touched module	Max score
New/changed behavior with config/lookup split across 2+ places (SSoT)	7
Same resolution block copied in 2+ functions in diff scope (DRY)	7
Predictable extension requires editing 3+ points in same file (weak OCP, e.g. provider)	7
Diff correct, zero Critical, mediocre / inconsistent pattern in file	7–8

9: zero Critical and smells above absent or resolved in touched module; predictable extension = one SSoT.

10: same as 9 plus no obvious fallback/redundancy; uniform pattern across file.

Anti-inflation

Forbidden: “minimal diff / tests pass / AC ok ⇒ 10”
Required in Executive Summary: one sentence justifying score vs rubric (e.g. “cap 7 — apiKey outside preset”)

Smell severity (SSoT / DRY / weak OCP)

Split SSoT or duplicated resolution in touched module ≥ Warning (not Suggestion only). Prefer Warning + score cap over auto-Critical for these smells. Keep Critical for bugs, security, AC failures. Score ≤ 8 already forces

Rejected

Review priorities

Within each section, order by severity:

Critical (must fix before merge)
Warning (should fix)
Suggestion (consider)

Diff touches

agent-api

(or LangGraph runtime paths): load

../ns-langgraph-agents/references/anti-patterns.md

. Placement, Prompt inject, Bind parity, Spec drift, colon wire names = Critical if violated.

SOLID and clean code

SRP, OCP, LSP, ISP, DIP
Naming, cyclomatic complexity, error handling, dead code

Performance, security, testability

N+1, unnecessary renders, missing validation
SQL injection, XSS, sensitive logs
Coupling that blocks testing

Required output format

Approved

Executive Summary

Score 1–10 (Score gate — pass ≥9, ideal 10)
One sentence justifying score vs score-cap rubric
Two-line overall assessment

Then:

Code Review: Approved

Rejected / Blocked

Executive Summary

Score 1–10
One sentence justifying score
Two-line overall assessment

Fix map (agent)

references/review-fix-map.template.md

— actionable correction rows only. Omit positive findings, suggestions-only noise, history, long prose.

Then:

Code Review: Rejected

Code Review: Blocked

Constraints

Read-only. No edit/create/delete product files — including
```
code-review-report.md
```
Not substitutable. Workflow callers must invoke this skill by name; platform review subagents not equivalent unless human explicitly requests them this run
Direct, constructive; no personal criticism
No rewrite unrelated code
Findings from actual diff + rules read
Match project conventions visible in codebase
Fix map audience = another agent, not human

References

File	When
`references/review-fix-map.template.md`	Rejected/Blocked response body
`../../ns-harness/references/artifact-layout.md`	Artifact paths
`mcp-gitlab-usage`	Posting internal review comments

ns-reviewer

NPX Install

Tags

SKILL.md Content

Code Reviewer

Caller contract (workflow callers)

Session boot

Workflow

Ad-hoc diff mode (from
`ns-coder`
)

Version closure

Issue review mode

Score gate (all modes)

Scoring unit

Score caps (lowest that fits)

Anti-inflation

Smell severity (SSoT / DRY / weak OCP)

Review priorities

SOLID and clean code

Performance, security, testability

Required output format

Approved

Executive Summary

Rejected / Blocked

Executive Summary

Fix map (agent)

Constraints

References

ns-reviewer

NPX Install

Tags

SKILL.md Content

Code Reviewer

Caller contract (workflow callers)

Session boot

Workflow

Ad-hoc diff mode (from ns-coder)

Version closure

Issue review mode

Score gate (all modes)

Scoring unit

Score caps (lowest that fits)

Anti-inflation

Smell severity (SSoT / DRY / weak OCP)

Review priorities

SOLID and clean code

Performance, security, testability

Required output format

Approved

Executive Summary

Rejected / Blocked

Executive Summary

Fix map (agent)

Constraints

References

Ad-hoc diff mode (from
`ns-coder`
)