ln-631-test-business-logic-auditor

Compare original and translation side by side

🇺🇸

Original

English
🇨🇳

Translation

Chinese

Business Logic Focus Auditor (L3 Worker)

聚焦业务逻辑的审计器(L3工作器)

Specialized worker auditing tests for Business Logic Focus (Category 1).
专注于审计测试用例的业务逻辑聚焦情况(类别1)的专用工作器。

Purpose & Scope

目的与范围

  • Worker in ln-630 coordinator pipeline
  • Audit Business Logic Focus (Category 1: High Priority)
  • Detect tests validating framework/library behavior (NOT our code)
  • Calculate compliance score (X/10)
  • ln-630协调器流水线中的工作器
  • 审计业务逻辑聚焦(类别1:高优先级)
  • 检测验证框架/库行为(而非自有代码)的测试用例
  • 计算合规性得分(X/10)

Inputs (from Coordinator)

输入(来自协调器)

Receives
contextStore
with framework detection patterns, tech stack, test file list.
接收包含框架检测模式、技术栈、测试文件列表的
contextStore

Workflow

工作流程

  1. Parse context
  2. Scan test files for framework/library tests
  3. Collect findings
  4. Calculate score
  5. Return JSON
  1. 解析上下文
  2. 扫描测试文件,查找框架/库相关测试用例
  3. 收集检测结果
  4. 计算得分
  5. 返回JSON格式结果

Audit Rules

审计规则

1. Framework Tests Detection

1. 框架测试用例检测

What: Tests validating framework behavior (Express, Fastify, Koa) instead of OUR business logic
Detection Patterns:
  • (express|fastify|koa).(use|get|post|put|delete|patch)
  • Test names: "middleware is called", "route handler works", "Express app listens"
Severity: MEDIUM
Recommendation: DELETE — framework already tested by maintainers
Effort: S (delete test file or test block)
检测内容: 验证框架行为(Express、Fastify、Koa)而非自有业务逻辑的测试用例
检测模式:
  • (express|fastify|koa).(use|get|post|put|delete|patch)
  • 测试名称:"middleware is called"、"route handler works"、"Express app listens"
严重程度: 中等
建议: 删除——框架已由维护者完成测试
工作量: S(删除测试文件或测试块)

2. ORM/Database Library Tests

2. ORM/数据库库测试用例检测

What: Tests validating Prisma/Mongoose/Sequelize/TypeORM behavior
Detection Patterns:
  • (prisma|mongoose|sequelize|typeorm).(find|findMany|create|update|delete|upsert)
  • Test names: "Prisma findMany returns array", "Mongoose save works"
Severity: MEDIUM
Recommendation: DELETE — ORM already tested
Effort: S
检测内容: 验证Prisma/Mongoose/Sequelize/TypeORM行为的测试用例
检测模式:
  • (prisma|mongoose|sequelize|typeorm).(find|findMany|create|update|delete|upsert)
  • 测试名称:"Prisma findMany returns array"、"Mongoose save works"
严重程度: 中等
建议: 删除——ORM已由官方完成测试
工作量: S

3. Crypto/Hashing Library Tests

3. 加密/哈希库测试用例检测

What: Tests validating bcrypt/argon2 hashing behavior
Detection Patterns:
  • (bcrypt|argon2).(hash|compare|verify|hashSync)
  • Test names: "bcrypt hashes password", "argon2 compares correctly"
Severity: MEDIUM
Recommendation: DELETE — crypto libraries already tested
Effort: S
检测内容: 验证bcrypt/argon2哈希行为的测试用例
检测模式:
  • (bcrypt|argon2).(hash|compare|verify|hashSync)
  • 测试名称:"bcrypt hashes password"、"argon2 compares correctly"
严重程度: 中等
建议: 删除——加密库已由官方完成测试
工作量: S

4. JWT/Token Library Tests

4. JWT/令牌库测试用例检测

What: Tests validating JWT signing/verification
Detection Patterns:
  • (jwt|jsonwebtoken).(sign|verify|decode)
  • Test names: "JWT signs token", "JWT verifies signature"
Severity: MEDIUM
Recommendation: DELETE — JWT library already tested
Effort: S
检测内容: 验证JWT签名/验证行为的测试用例
检测模式:
  • (jwt|jsonwebtoken).(sign|verify|decode)
  • 测试名称:"JWT signs token"、"JWT verifies signature"
严重程度: 中等
建议: 删除——JWT库已由官方完成测试
工作量: S

5. HTTP Client Library Tests

5. HTTP客户端库测试用例检测

What: Tests validating axios/fetch/got behavior
Detection Patterns:
  • (axios|fetch|got|request).(get|post|put|delete|patch)
  • Test names: "axios makes GET request", "fetch returns data"
Severity: MEDIUM
Recommendation: DELETE — HTTP clients already tested
Effort: S
检测内容: 验证axios/fetch/got行为的测试用例
检测模式:
  • (axios|fetch|got|request).(get|post|put|delete|patch)
  • 测试名称:"axios makes GET request"、"fetch returns data"
严重程度: 中等
建议: 删除——HTTP客户端已由官方完成测试
工作量: S

6. React Hooks/Framework Tests

6. React Hooks/框架测试用例检测

What: Tests validating React hooks behavior (useState, useEffect, etc.)
Detection Patterns:
  • (useState|useEffect|useContext|useReducer|useMemo|useCallback)
  • Test names: "useState updates state", "useEffect runs on mount"
Severity: LOW (acceptable if testing OUR custom hook logic)
Recommendation: REVIEW — if testing framework behavior → DELETE; if testing custom hook → KEEP
Effort: S-M
检测内容: 验证React hooks行为(useState、useEffect等)的测试用例
检测模式:
  • (useState|useEffect|useContext|useReducer|useMemo|useCallback)
  • 测试名称:"useState updates state"、"useEffect runs on mount"
严重程度: (若测试自有自定义hook逻辑则可接受)
建议: 审核——若测试框架行为则删除;若测试自定义hook则保留
工作量: S-M

Scoring Algorithm

评分算法

See
shared/references/audit_scoring.md
for unified formula and score interpretation.
统一的计算公式和得分说明请参见
shared/references/audit_scoring.md

Output Format

输出格式

Return JSON to coordinator:
json
{
  "category": "Business Logic Focus",
  "score": 7,
  "total_issues": 12,
  "critical": 0,
  "high": 0,
  "medium": 10,
  "low": 2,
  "checks": [
    {"id": "framework_tests", "name": "Framework Tests Detection", "status": "failed", "details": "Found 6 tests validating Express/Fastify behavior"},
    {"id": "orm_tests", "name": "ORM Library Tests", "status": "warning", "details": "Found 4 Prisma validation tests"},
    {"id": "business_logic_coverage", "name": "Business Logic Coverage", "status": "passed", "details": "Core business logic properly tested"}
  ],
  "findings": [
    {
      "severity": "MEDIUM",
      "location": "auth.test.ts:45-52",
      "issue": "Test 'bcrypt hashes password' validates library behavior, not OUR code",
      "principle": "Business Logic Focus / Framework Testing",
      "recommendation": "Delete test — bcrypt already tested by maintainers",
      "effort": "S"
    },
    {
      "severity": "MEDIUM",
      "location": "db.test.ts:78-85",
      "issue": "Test 'Prisma findMany returns array' validates ORM behavior, not OUR query logic",
      "principle": "Business Logic Focus / ORM Testing",
      "recommendation": "Delete test — Prisma already tested",
      "effort": "S"
    }
  ]
}
向协调器返回JSON格式结果:
json
{
  "category": "Business Logic Focus",
  "score": 7,
  "total_issues": 12,
  "critical": 0,
  "high": 0,
  "medium": 10,
  "low": 2,
  "checks": [
    {"id": "framework_tests", "name": "Framework Tests Detection", "status": "failed", "details": "Found 6 tests validating Express/Fastify behavior"},
    {"id": "orm_tests", "name": "ORM Library Tests", "status": "warning", "details": "Found 4 Prisma validation tests"},
    {"id": "business_logic_coverage", "name": "Business Logic Coverage", "status": "passed", "details": "Core business logic properly tested"}
  ],
  "findings": [
    {
      "severity": "MEDIUM",
      "location": "auth.test.ts:45-52",
      "issue": "Test 'bcrypt hashes password' validates library behavior, not OUR code",
      "principle": "Business Logic Focus / Framework Testing",
      "recommendation": "Delete test — bcrypt already tested by maintainers",
      "effort": "S"
    },
    {
      "severity": "MEDIUM",
      "location": "db.test.ts:78-85",
      "issue": "Test 'Prisma findMany returns array' validates ORM behavior, not OUR query logic",
      "principle": "Business Logic Focus / ORM Testing",
      "recommendation": "Delete test — Prisma already tested",
      "effort": "S"
    }
  ]
}

Reference Files

参考文件

  • Audit scoring formula:
    shared/references/audit_scoring.md
  • Audit output schema:
    shared/references/audit_output_schema.md

Version: 3.0.0 Last Updated: 2025-12-23
  • 审计评分公式:
    shared/references/audit_scoring.md
  • 审计输出Schema:
    shared/references/audit_output_schema.md

版本: 3.0.0 最后更新时间: 2025-12-23