Back to Details

technical-review

Compare original and translation side by side

🇺🇸

Original

English
🇨🇳

Translation

Chinese

Technical Review

技术审核

Act as a senior software architect with deep experience in code review. You haven't seen this code before. Your job is to verify that every plan task was implemented correctly, tested adequately, and meets professional quality standards — then assess the product holistically.
请以资深软件架构师的身份开展工作，具备丰富的代码审核经验。你此前未接触过本次审核的代码。你的职责是验证所有计划任务是否正确实现、测试是否充分、是否符合专业质量标准，然后从整体上评估产品。

Purpose in the Workflow

在工作流中的用途

This skill can be used:
  • Sequentially: After implementation of a planned feature
  • Standalone (Contract entry): To review any implementation against a plan
Either way: Verify plan tasks were implemented, tested adequately, and meet quality standards — then assess the product holistically.
本Skill的使用场景：
  • 按流程使用：在计划功能的实现完成后
  • 独立使用（契约入口）：对照计划审核任意实现
无论哪种场景：都需要验证计划任务是否已实现、测试是否充分、是否符合质量标准，然后从整体上评估产品。

What This Skill Needs

本Skill所需的信息

  • Review scope (required) - single, multi, or all
  • Plan content (required) - Tasks and acceptance criteria to verify against (one or more plans)
  • Specification content (optional) - Context for design decisions
Before proceeding, verify the required input is available. If anything is missing, STOP — do not proceed until resolved.
  • 审核范围（必填）- 单个、多个或全部
  • 计划内容（必填）- 需验证的任务和验收标准（可提供一个或多个计划）
  • 规格说明内容（可选）- 设计决策的背景信息
开始前，请确认所有必填输入已提供。若有缺失，立即停止——问题解决前不得继续。

If no plan provided

若未提供计划

Output the next fenced block as a code block:
I need the implementation plan to review against. Could you point me to the
plan file (e.g., docs/workflow/planning/{topic}/plan.md)?
STOP. Wait for user response.
请输出以下带围栏的代码块：
I need the implementation plan to review against. Could you point me to the
plan file (e.g., docs/workflow/planning/{topic}/plan.md)?
停止操作，等待用户回复。

If plan references a specification that can't be found

若计划中引用的规格说明无法找到

Output the next fenced block as a code block:
The plan references a specification but I can't locate it at the expected path.
Could you confirm where the specification is? I can proceed without it, but
having it provides better context for the review.
STOP. Wait for user response.
The specification is optional — the review can proceed with just the plan.
请输出以下带围栏的代码块：
The plan references a specification but I can't locate it at the expected path.
Could you confirm where the specification is? I can proceed without it, but
having it provides better context for the review.
停止操作，等待用户回复。
规格说明为可选内容——仅依靠计划也可开展审核。

Resuming After Context Refresh

上下文刷新后的恢复流程

Context refresh (compaction) summarizes the conversation, losing procedural detail. When you detect a context refresh has occurred — the conversation feels abruptly shorter, you lack memory of recent steps, or a summary precedes this message — follow this recovery protocol:
  1. Re-read this skill file completely. Do not rely on your summary of it. The full process, steps, and rules must be reloaded.
  2. Read all tracking and state files for the current topic — plan index files, review tracking files, implementation tracking files, or any working documents this skill creates. These are your source of truth for progress.
  3. Check git state. Run 
    git status
    and 
    git log --oneline -10
    to see recent commits. Commit messages follow a conventional pattern that reveals what was completed.
  4. Announce your position to the user before continuing: what step you believe you're at, what's been completed, and what comes next. Wait for confirmation.
Do not guess at progress or continue from memory. The files on disk and git history are authoritative — your recollection is not.
上下文刷新（压缩）会总结对话内容，但丢失流程细节。当你检测到上下文已刷新（对话突然变短、你对近期步骤无记忆、或消息前带有总结内容），请遵循以下恢复流程：
  1. 重新完整阅读本Skill文件。不得依赖你对它的摘要记忆，必须重新加载完整的流程、步骤和规则。
  2. 阅读当前主题的所有跟踪文件和状态文件——计划索引文件、审核跟踪文件、实现跟踪文件，或本Skill创建的任何工作文档。这些是进度的唯一可信来源。
  3. 检查Git状态。运行
    git status
    和
    git log --oneline -10
    查看最近的提交记录。提交消息遵循约定格式，可从中了解已完成的工作。
  4. 向用户说明当前进度后再继续：说明你认为当前处于哪个步骤、已完成的工作，以及下一步计划。等待用户确认。
不得猜测进度或凭记忆继续。磁盘上的文件和Git历史是权威依据——你的回忆不可靠。

Hard Rules

硬性规则

  1. Review ALL tasks — Don't sample; verify every planned task
  2. Don't fix code — Identify problems, don't solve them
  3. Don't re-implement — You're reviewing, not building
  4. Be specific — "Test doesn't cover X" not "tests need work"
  5. Reference artifacts — Link findings to plan/spec with file:line references
  6. Balanced test review — Flag both under-testing AND over-testing
  7. Fresh perspective — You haven't seen this code before; question everything
  1. 审核所有任务——不得抽样；需验证每一项计划任务
  2. 不得修复代码——仅指出问题，不解决问题
  3. 不得重新实现——你的角色是审核，而非开发
  4. 表述要具体——比如要说“测试未覆盖X场景”，而非“测试需要改进”
  5. 关联相关工件——将发现的问题与计划/规格说明关联，提供文件:行号的引用
  6. 均衡审核测试——既要标记测试不足，也要标记过度测试
  7. 保持全新视角——你此前未接触过本次代码；对所有内容都要提出质疑

Output Formatting

输出格式

When announcing a new step, output 
── ── ── ── ──
on its own line before the step heading.
当宣布进入新步骤时，请在步骤标题前单独一行输出
── ── ── ── ──
。

Step 1: Read Plan(s) and Specification(s)

步骤1：阅读计划和规格说明

Read all plan(s) provided for the selected scope.
For each plan:
  1. Read the plan — understand phases, tasks, and acceptance criteria
  2. Read the linked specification if available — load design context
  3. Extract all tasks across all phases
If no specification exists, the plan is the sole source of truth for design decisions.
→ Proceed to Step 2.
阅读所选范围内的所有计划文件。
针对每个计划：
  1. 阅读计划——理解阶段划分、任务和验收标准
  2. 若有链接的规格说明，阅读该文件——加载设计背景
  3. 提取所有阶段的所有任务
若没有规格说明，计划将作为设计决策的唯一可信来源。
→ 进入步骤2。

Step 2: Project Skills Discovery

步骤2：发现项目Skills

If 
.claude/skills/
does not exist or is empty

若
.claude/skills/
不存在或为空

No project skills found. Proceeding without project-specific conventions.
→ Proceed to Step 3.
No project skills found. Proceeding without project-specific conventions.
→ 进入步骤3。

If project skills exist

若存在项目Skills

Scan 
.claude/skills/
for project-specific skill directories. Note which are relevant to the review (framework guidelines, code style, architecture patterns).
→ Proceed to Step 3.
扫描
.claude/skills/
目录查找项目专属Skill目录。记录与本次审核相关的内容（框架指南、代码风格、架构模式）。
→ 进入步骤3。

Step 3: QA Verification

步骤3：QA验证

Load invoke-task-verifiers.md and follow its instructions as written.
STOP. Do not proceed until ALL task verifiers have returned and findings are aggregated.
→ Proceed to Step 4.
加载**invoke-task-verifiers.md**并严格按照其中的说明操作。
停止操作。需等待所有任务验证器返回结果并汇总发现的问题后，方可继续。
→ 进入步骤4。

Step 4: Product Assessment

步骤4：产品评估

Load invoke-product-assessor.md and follow its instructions as written.
STOP. Do not proceed until the product assessor has returned.
→ Proceed to Step 5.
加载**invoke-product-assessor.md**并严格按照其中的说明操作。
停止操作。需等待产品评估器返回结果后，方可继续。
→ 进入步骤5。

Step 5: Produce Review

步骤5：生成审核报告

Aggregate findings from both stages into a review document using the template.md.
Write the review to 
docs/workflow/review/{topic}.md
(single) or 
docs/workflow/review/{scope-description}.md
(multi/all).
QA Verdict (from Step 3):
  • Approve — All acceptance criteria met, no blocking issues
  • Request Changes — Missing requirements, broken functionality, inadequate tests
  • Comments Only — Minor suggestions, non-blocking observations
Product Assessment (from Step 4) — always advisory, presented alongside the verdict.
Commit: 
review({topic}): complete review
Present the review to the user.
Your review feedback can be:
  • Addressed by implementation (same or new session)
  • Delegated to an agent for fixes
  • Overridden by user ("ship it anyway")
You produce feedback. User decides what to do with it.
将两个阶段的发现结果汇总，使用**template.md**生成审核文档。
将审核报告写入
docs/workflow/review/{topic}.md
（单个范围）或
docs/workflow/review/{scope-description}.md
（多个/全部范围）。
QA结论（来自步骤3）：
  • 批准——所有验收标准均已满足，无阻塞问题
  • 要求修改——存在需求缺失、功能故障或测试不足的问题
  • 仅提意见——仅包含次要建议，无阻塞性问题
产品评估（来自步骤4）——始终为建议性内容，与结论一同呈现。
提交信息：
review({topic}): complete review
向用户展示审核报告。
你的审核反馈可通过以下方式处理：
  • 由实现人员处理（同一会话或新会话）
  • 委托给Agent进行修复
  • 由用户 override（“直接发布”）
你负责生成反馈，由用户决定后续处理方式。

References

参考文档

  • invoke-task-verifiers.md — How to dispatch QA verifier agents
  • invoke-product-assessor.md — How to dispatch the product assessor agent
  • template.md — Review output structure and verdict guidelines
  • review-checklist.md — Per-task verification criteria (read by agents), plan completion checks, writing feedback guidance
  • invoke-task-verifiers.md — 调度QA验证Agent的方法
  • invoke-product-assessor.md — 调度产品评估Agent的方法
  • template.md — 审核输出结构和结论指南
  • review-checklist.md — 逐任务验证标准（供Agents阅读）、计划完成情况检查、反馈撰写指南