factory-review

Compare original and translation side by side

🇺🇸

Original

English
🇨🇳

Translation

Chinese

Factory Review

工厂模式审查

Value: Communication -- factory mode concentrates the human's attention on decisions that matter. This skill ensures the review interface is clear, concise, and actionable so the human can provide meaningful oversight without re-reading every line of code.
价值: 沟通协作——工厂模式将人工注意力集中在关键决策上。该Skill确保审查界面清晰、简洁且具备可操作性,让人工无需逐行重读代码就能提供有意义的监督。

Purpose

目标

Structures the human review experience during Phase 3 of factory-mode builds. Produces audit trail summaries, PR digests, retrospective synthesis, quality trend reports, and an autonomy tuning interface. The goal is high-signal review in minimal time.
为工厂模式构建的第三阶段打造人工审查体验框架。生成审计跟踪摘要、PR摘要、回顾总结、质量趋势报告以及自主调优界面。目标是用最短时间完成高价值信号的审查。

Practices

实践规范

Audit Trail Summary

审计跟踪摘要

Read from
.factory/audit-trail/
and present a concise build summary:
  • Slices completed: Count and list (by slice ID and title)
  • Rework rate: Percentage of slices that required rework cycles
  • Gate failure distribution: Count of failures by gate type (tdd, review, ci, mutation)
  • Escalations pending: Count and brief description of each unresolved escalation
Format as a dashboard-style summary. Lead with the numbers, follow with details only if the human asks.
读取
.factory/audit-trail/
目录下的内容,呈现简洁的构建摘要:
  • 已完成切片: 数量及列表(按切片ID和标题)
  • 返工率: 需要返工的切片占比
  • 关卡失败分布: 各类型关卡(tdd、review、ci、mutation)的失败次数
  • 待处理升级项: 每个未解决升级项的数量及简要描述
以仪表盘风格的摘要形式呈现。优先展示数据,仅在人工询问时提供详细信息。

PR Digest

PR摘要

For each merged PR in the build, produce a one-paragraph summary:
  1. What changed: Feature or fix description in plain language
  2. Which slice: The vertical slice ID this PR implements
  3. Which pair: The two engineers who built it
  4. Gate results: Pass/fail for each quality gate (tdd, review, ci, mutation)
  5. Rework count: Number of rework cycles before all gates passed
Keep each digest to 3-5 sentences. The human should be able to scan all PR digests in under a minute for a typical build session.
针对构建中每个已合并的PR,生成一段摘要:
  1. 变更内容: 用平实语言描述功能或修复点
  2. 所属切片: 该PR实现的垂直切片ID
  3. 开发人员对: 负责构建的两名工程师
  4. 关卡结果: 各质量关卡(tdd、review、ci、mutation)的通过/失败情况
  5. 返工次数: 所有关卡通过前的返工周期数
每个摘要控制在3-5句话。对于典型的构建会话,人工应能在一分钟内浏览完所有PR摘要。

Retrospective Synthesis

回顾总结

Aggregate findings from team retrospectives (stored in
.factory/audit-trail/retrospectives/
) and surface patterns:
  • Recurring rework causes: What kinds of issues triggered the most rework?
  • Pair effectiveness: Which pairings produced the fewest rework cycles?
  • Domain hotspots: Which areas of the domain model generated the most discussion or revision?
  • Process friction: Any team-identified impediments or improvement suggestions
Present as bullet points grouped by theme. Do not editorialize -- report what the team said.
汇总团队回顾会议的结果(存储在
.factory/audit-trail/retrospectives/
目录下),提炼模式:
  • 常见返工原因: 哪些类型的问题导致了最多返工?
  • 结对效率: 哪些结对组合的返工次数最少?
  • 领域热点: 领域模型的哪些区域引发了最多讨论或修订?
  • 流程摩擦: 团队指出的任何障碍或改进建议
按主题分组以项目符号形式呈现。不得加入主观评论,仅如实报告团队的反馈内容。

Quality Trend Tracking

质量趋势跟踪

Read from
.factory/audit-trail/metrics/
and present trends:
MetricCurrentPreviousTrend
Mutation score%%up/down/stable
Rework rate%%up/down/stable
Cycle time per slicedurationdurationup/down/stable
Gate failure rate by typecountscountsup/down/stable
"Previous" means the last completed build session. If no previous session exists, omit the comparison column.
读取
.factory/audit-trail/metrics/
目录下的内容,呈现趋势数据:
指标当前值历史值趋势
突变测试得分%%上升/下降/稳定
返工率%%上升/下降/稳定
每切片周期时长时长时长上升/下降/稳定
各类型关卡失败率次数次数上升/下降/稳定
“历史值”指上一次完成的构建会话。若不存在上一次会话,则省略对比列。

Tuning Interface

调优界面

Accept adjustments to
.factory/config.yaml
during review. For each proposed change:
  1. Validate: Check that the change is consistent (e.g., cannot enable auto-merge at
    conservative
    autonomy level; cannot disable a gate that another setting depends on)
  2. Explain implications: What will change in behavior if this setting is modified? Be specific.
  3. Apply or reject: If valid, apply the change. If invalid, explain why and suggest the nearest valid alternative.
Never apply config changes silently. Always confirm with the human before writing to
.factory/config.yaml
.
在审查期间支持对
.factory/config.yaml
进行调整。针对每个提议的变更:
  1. 验证: 检查变更是否符合规则(例如:在
    conservative
    自主级别下无法启用自动合并;无法禁用其他设置依赖的关卡)
  2. 说明影响: 修改该设置后,行为会发生哪些具体变化?
  3. 应用或拒绝: 若变更有效,则应用;若无效,说明原因并建议最接近的有效替代方案。
不得静默应用配置变更。在写入
.factory/config.yaml
前,必须获得人工确认。

Escalation Review

升级项审查

Present each pending escalation with full context:
  1. Which gate: The quality gate that triggered the escalation
  2. Rework attempts: How many rework cycles were attempted
  3. What was tried: Brief summary of each rework attempt
  4. Current state: What the code looks like now (diff or description)
  5. Recommendation: The team's suggested resolution (if any)
The human decides: resolve, override, or send back for more rework.
完整呈现每个待处理升级项的上下文:
  1. 触发关卡: 触发升级的质量关卡
  2. 返工尝试次数: 已尝试的返工周期数
  3. 尝试内容: 每次返工尝试的简要总结
  4. 当前状态: 代码的当前状态(差异或描述)
  5. 建议方案: 团队提出的解决建议(如有)
由人工决定:解决、覆盖或退回重新返工。

Enforcement Note

实施说明

This skill provides advisory guidance for structuring the review experience. It reads from audit trail files produced by the pipeline and presents them in a human-friendly format. It cannot enforce that the human reviews every item -- it can only make the review efficient and thorough.
该Skill为构建审查体验提供指导性建议。它读取流水线生成的审计跟踪文件,并以人性化的格式呈现。它无法强制人工审查每一项内容——只能让审查过程更高效、更全面。

Verification

验证

After completing a factory review session, verify:
  • Audit trail summary was presented with current build metrics
  • Every merged PR has a digest (no PRs skipped)
  • Retrospective synthesis covers all team retrospectives from the session
  • Quality trends include comparison to previous session (if available)
  • All pending escalations were presented with full context
  • Any config changes were validated before being applied
  • Human confirmed or overrode each escalation
If any criterion is not met, revisit the relevant practice.
完成工厂模式审查会话后,验证以下内容:
  • 已呈现包含当前构建指标的审计跟踪摘要
  • 每个已合并的PR都有对应的摘要(无遗漏)
  • 回顾总结涵盖了会话中所有团队回顾内容
  • 质量趋势包含与上一次会话的对比(若有)
  • 所有待处理升级项都已完整呈现上下文
  • 任何配置变更在应用前都经过了验证
  • 人工已确认或覆盖每个升级项
若有任何一项未满足,请重新检查对应的实践规范。

Dependencies

依赖项

This skill requires the
pipeline
skill for factory mode infrastructure. It integrates with:
  • pipeline: Reads audit trail files and metrics produced by the pipeline orchestrator during Phase 2
  • ensemble-team: Retrospective synthesis reads team retro output; pair effectiveness data comes from pairing history
  • ci-integration: Gate failure data includes CI_RESULT packets from the ci-integration skill
Missing a dependency? Install with:
npx skills add jwilger/agent-skills --skill pipeline
该Skill依赖
pipeline
Skill以获取工厂模式的基础设施支持。它与以下组件集成:
  • pipeline: 读取第二阶段由流水线编排器生成的审计跟踪文件和指标
  • ensemble-team: 回顾总结读取团队回顾输出;结对效率数据来自结对历史
  • ci-integration: 关卡失败数据包含来自ci-integration Skill的CI_RESULT数据包
缺少依赖项?使用以下命令安装:
npx skills add jwilger/agent-skills --skill pipeline