Review the change, not just the code it left behind
A diff is not a surface. The lines a change deletes matter as much as the lines it adds, and the file it touches is rarely the whole of what it affects.
This skill owns change scope only: resolving the target, expanding changed files to affected surfaces, reading both sides of the diff, and classifying each finding. Domain rules belong to the six
skills. Mode, severity, consolidation, coverage, the cap, the output format, and the verdict belong to
, which this skill hands the review to. Never duplicate or override their rules here.
Correctness, tests, security, and performance belong to the project's general code review. Name the concern once and move on.
Quick Reference
| Category | When to Use |
|---|
| Scope Resolution | Targets and commands, default branch, merge-base, PR and fork refs, repository states, renames, exclusions, consumer expansion |
| Removed Signals | What to look for on the side of a hunk and which skill owns each removal |
Core Principles
1. Resolve the Change Scope First
owns mode parsing; everything after the mode is the target, so
/interface-review quick pr 482
is a
review of pull request 482.
Scope Resolution holds the accepted targets and the command for each.
With no target supplied, resolve in this order and stop at the first match:
- is ahead of
git merge-base origin/<default-branch> HEAD
- The working tree is dirty: the uncommitted changes.
- Otherwise, , stated as a fallback.
Order matters: checking the working tree first lets one stray formatting edit shadow a twelve-commit branch while the report still claims full coverage.
Exclude lockfiles, snapshots, generated output, vendored code, and binaries, and name what you excluded. If the scope is empty after exclusions, say so and stop.
2. A Diff Is Not a Surface
A changed file is evidence, not the review subject. Expand each one to the surfaces it renders in and review those.
Expand one hop by default: the direct importers and callers. Expand a second hop only for design tokens, theme values, and shared primitives, where one line reaches the whole product.
Review at most five consumers, ordered by the rule in Scope Resolution, and state how many you did not expand. An unbounded sweep produces coverage claims you cannot support; an unstated cutoff produces a report that looks complete and is not.
3. Read the Removed Lines
Regressions are invisible in the post-change state. Read the
side of every hunk against
Removed Signals.
A signal is a lead, not a finding. A removal is only a regression when nothing in the change replaces it, and the domain skill owns that judgement. Route each unmatched removal to its owner and report only what that skill confirms. Then status it
, which tells the author they broke something that worked rather than made a new mistake.
4. Classify Every Finding
Give every finding one status:
- : the change created it.
- : the change weakened something previously correct.
- : present in the touched code but not caused by this change.
Status by what the diff touched, not by which file it sits in: a line the change never touched is
even three lines from a hunk. Confirm against the base ref when it matters:
bash
git blame -L <line>,<line> "$BASE" -- path/to/file
Hand every finding up with its status attached and let
apply its cap and verdict rules.
5. Hold the Change to Its Stated Intent
Read the pull request title and body, the linked issue, and the commit messages, then review whether the interface delivers what they claim.
This is what surfaces the incomplete change, which a surface review cannot see because it inspects states when present and here the point is that they are absent:
- A new variant, size, or theme applied to some states but not all: hover, focus, active, disabled, loading, selected.
- A new user-facing string with no entry in the translation catalogue the project maintains.
- A new component with no empty, loading, error, disabled, or narrow-width state.
- A control added to one surface but not to the siblings that already carry its peers.
Do not report scope creep. Whether a change does too much is a process question, not an interface one.
6. Hand the Review to
With the scope, the affected surfaces, and both sides of the diff in hand, hand the review to
with the scope block and a status on every finding. It routes to the six domain skills, applies severity, consolidates, enforces the cap, and issues the verdict, including the change-scoped rules under its
Change-Scoped Reviews section.
If
is unavailable, report the resolved scope and the file inventory, name it as the missing skill, and stop. Do not invent a severity scale, a cap, or a verdict.
7. Never Mutate the Working Tree
A change review is read-only, including the checkout. Fetch pull request refs; never check them out.
writes only to
and is permitted.
,
,
, and
rewrite the files the author has open, failing against local edits or discarding them, and are never permitted in any mode.
Rendered verification is opt-in: mark visual and runtime claims
Not verified unless the project exposes a cheap preview or the user asks for a rendered review. When they do, use an isolated worktree (
git worktree add /tmp/review-<n> refs/remotes/pr/<n>
) and remove it when done. That leaves the author's tree untouched, which a checkout does not, so a checkout is not an alternative here.
Common Mistakes
| Mistake | Fix |
|---|
| One stray edit reviewed instead of the branch | Check before the working tree, and report both counts |
| Hunks reviewed without their consumers | Expand one hop, two for tokens and primitives, and name what you skipped |
| Only the side of the diff read | Search the side for removed accessibility, focus, motion, and text signals |
| An equivalent replacement reported as a regression | Route the removal to the owning skill and report only what it confirms |
| A removal reported as a new mistake | Status it so the author knows it used to work |
| A line near a hunk statused | Status by what the diff touched, confirmed with against the base ref |
| A pull request checked out to review it | Fetch the ref and review it in place |
| Line numbers cited that do not exist on the reviewed ref | Cite against the head ref named in the scope block |
| Mode, severity, caps, the output format, or the verdict restated here | Defer to |
| Correctness, test, or security findings in the report | Name the concern once, point at the project's code review, and drop it |
Review Output Format
owns the format, including the four change-scoped additions under its
Change-Scoped Reviews section. Follow it as written and add nothing here.
This skill supplies the scope block:
| Field | Value |
|---|
| Target | , , , , or the range as entered |
| Base ref | at |
| Head ref | at |
| Commits | 7 committed, 2 files uncommitted |
| Files in scope | 12 after exclusions |
| Excluded | , : lockfile and snapshots |
| Surfaces expanded | , ; 3 further consumers not expanded |
Plus a status on every finding, per principle 4.
Under
's
Verification, list the exact
and
commands and their results, including every write to
(a fetch, a deepen, a
, a worktree), so the read-only claim in principle 7 is auditable.