code-reviewer

Compare original and translation side by side

🇺🇸

Original

English

🇨🇳

Chinese

This skill guides the agent in conducting professional and thorough code reviews for both local development and remote Pull Requests.

该Skill可指导Agent针对本地开发代码和远程Pull Requests开展专业、全面的代码审查工作。

Remote PR: If the user provides a PR number or URL (e.g., "Review PR #123"), target that remote PR.
Local Changes: If no specific PR is mentioned, or if the user asks to "review my changes", target the current local file system states (staged and unstaged changes).

Checkout: Use the GitHub CLI to checkout the PR.
bash
```
gh pr checkout <PR_NUMBER>
```
Preflight: Execute the project's standard verification suite to catch automated failures early.
bash
```
npm run preflight
```
Context: Read the PR description and any existing comments to understand the goal and history.

Identify Changes:
- Check status:
```
git status
```
- Read diffs:
```
git diff
```
  (working tree) and/or
```
git diff --staged
```
  (staged).
Preflight (Optional): If the changes are substantial, ask the user if they want to run
```
npm run preflight
```
before reviewing.

识别变更内容：
- 查看状态：
```
git status
```
- 查看差异：
```
git diff
```
  （工作区）和/或
```
git diff --staged
```
  （已暂存）。
预检查（可选）：如果变更内容较多，询问用户是否要在审查前运行
```
npm run preflight
```
。

Analyze the code changes based on the following pillars:

Correctness: Does the code achieve its stated purpose without bugs or logical errors?
Maintainability: Is the code clean, well-structured, and easy to understand and modify in the future? Consider factors like code clarity, modularity, and adherence to established design patterns.
Readability: Is the code well-commented (where necessary) and consistently formatted according to our project's coding style guidelines?
Efficiency: Are there any obvious performance bottlenecks or resource inefficiencies introduced by the changes?
Security: Are there any potential security vulnerabilities or insecure coding practices?
Edge Cases and Error Handling: Does the code appropriately handle edge cases and potential errors?
Testability: Is the new or modified code adequately covered by tests (even if preflight checks pass)? Suggest additional test cases that would improve coverage or robustness.

基于以下维度分析代码变更：

Summary: A high-level overview of the review.
Findings:
- Critical: Bugs, security issues, or breaking changes.
- Improvements: Suggestions for better code quality or performance.
- Nitpicks: Formatting or minor style issues (optional).
Conclusion: Clear recommendation (Approved / Request Changes).

摘要：审查的高层级概述。
审查发现：
- 严重问题：bug、安全问题或破坏性变更。
- 改进建议：针对代码质量或性能的优化建议。
- 细节问题：格式或轻微风格问题（可选）。
结论：明确的审查结论（批准 / 请求修改）。