Loading...
Loading...
Compare original and translation side by side
useEffectuseEffectuseEffect// ❌ BAD: Double render cycle
function FilteredList({ items }) {
const [query, setQuery] = useState('');
const [filtered, setFiltered] = useState([]);
useEffect(() => {
setFiltered(items.filter(item => item.name.includes(query)));
}, [items, query]); // Renders twice on every input
return <ul>{filtered.map(item => <li key={item.id}>{item.name}</li>)}</ul>;
}// ✅ GOOD: Single render, no effect needed
function FilteredList({ items }) {
const [query, setQuery] = useState('');
// Calculated every render - no state, no effect
const filtered = items.filter(item => item.name.includes(query));
return <ul>{filtered.map(item => <li key={item.id}>{item.name}</li>)}</ul>;
}useEffect// ❌ 不良写法:触发两次渲染周期
function FilteredList({ items }) {
const [query, setQuery] = useState('');
const [filtered, setFiltered] = useState([]);
useEffect(() => {
setFiltered(items.filter(item => item.name.includes(query)));
}, [items, query]); // 每次输入都会触发两次渲染
return <ul>{filtered.map(item => <li key={item.id}>{item.name}</li>)}</ul>;
}// ✅ 推荐写法:单次渲染,无需effect
function FilteredList({ items }) {
const [query, setQuery] = useState('');
// 每次渲染时计算 - 无需额外状态,无需effect
const filtered = items.filter(item => item.name.includes(query));
return <ul>{filtered.map(item => <li key={item.id}>{item.name}</li>)}</ul>;
}// ❌ BAD: Shows old state briefly, then new
function UserForm({ userId }) {
const [userName, setUserName] = useState('');
const [email, setEmail] = useState('');
useEffect(() => {
setUserName(''); // First render shows old userName
setEmail(''); // Then this effect runs to reset
}, [userId]); // Double render every userId change
return (
<form>
<input value={userName} onChange={e => setUserName(e.target.value)} />
<input value={email} onChange={e => setEmail(e.target.value)} />
</form>
);
}// ✅ GOOD: React tears down and rebuilds component
function App() {
const [userId, setUserId] = useState(1);
return (
<div>
<button onClick={() => setUserId(prev => prev + 1)}>Next User</button>
{/* Different key = different component instance */}
<UserForm key={userId} userId={userId} />
</div>
);
}// ✅ GOOD: Only reset specific values, keep others
function UserForm({ userId }) {
const [userName, setUserName] = useSyncExternalStore(
() => ({ onSet: setUserName }), // Reset when userId changes
{ value: '' }
);
const [email, setEmail] = useState('');
// Email persists, userName resets
return <form>...</form>;
}key// ❌ 不良写法:先显示旧状态,再更新为新状态
function UserForm({ userId }) {
const [userName, setUserName] = useState('');
const [email, setEmail] = useState('');
useEffect(() => {
setUserName(''); // 首次渲染显示旧userName
setEmail(''); // 随后effect执行重置操作
}, [userId]); // 每次userId变化都会触发两次渲染
return (
<form>
<input value={userName} onChange={e => setUserName(e.target.value)} />
<input value={email} onChange={e => setEmail(e.target.value)} />
</form>
);
}// ✅ 推荐写法:React会卸载并重建组件
function App() {
const [userId, setUserId] = useState(1);
return (
<div>
<button onClick={() => setUserId(prev => prev + 1)}>下一个用户</button>
{/* 不同的key对应不同的组件实例 */}
<UserForm key={userId} userId={userId} />
</div>
);
}// ✅ 推荐写法:仅重置特定值,保留其他状态
function UserForm({ userId }) {
const [userName, setUserName] = useSyncExternalStore(
() => ({ onSet: setUserName }), // 当userId变化时重置
{ value: '' }
);
const [email, setEmail] = useState('');
// Email状态保留,userName状态重置
return <form>...</form>;
}// ❌ BAD: Effects trigger effects
function OrderForm() {
const [formData, setFormData] = useState({});
const [validated, setValidated] = useState(false);
const [error, setError] = useState(null);
// Effect 1: Validate when formData changes
useEffect(() => {
setValidated(validateData(formData));
}, [formData]);
// Effect 2: Set error when validation changes
useEffect(() => {
setError(validated ? null : 'Invalid');
}, [validated]);
// Effect 3: Submit when no error
useEffect(() => {
if (!error && validated) submitOrder(formData);
}, [error, validated, formData]);
}// ✅ GOOD: One handler, one render, clear flow
function OrderForm() {
const [formData, setFormData] = useState({});
const handleSubmit = () => {
// All logic happens atomically
if (validateData(formData)) {
submitOrder(formData); // No intermediate states
} else {
setError('Invalid form'); // Set directly, no cascade
}
};
return <button onClick={handleSubmit}>Submit</button>;
}// ❌ 不良写法:Effect互相触发
function OrderForm() {
const [formData, setFormData] = useState({});
const [validated, setValidated] = useState(false);
const [error, setError] = useState(null);
// Effect 1:当formData变化时验证
useEffect(() => {
setValidated(validateData(formData));
}, [formData]);
// Effect 2:当验证状态变化时设置错误信息
useEffect(() => {
setError(validated ? null : 'Invalid');
}, [validated]);
// Effect 3:无错误时提交表单
useEffect(() => {
if (!error && validated) submitOrder(formData);
}, [error, validated, formData]);
}// ✅ 推荐写法:单个处理器,单次渲染,流程清晰
function OrderForm() {
const [formData, setFormData] = useState({});
const handleSubmit = () => {
// 所有逻辑原子性执行
if (validateData(formData)) {
submitOrder(formData); // 无中间状态
} else {
setError('Invalid form'); // 直接设置,无级联
}
};
return <button onClick={handleSubmit}>Submit</button>;
}// ❌ BAD: Intent is lost, hard to follow
function LoginForm() {
const [username, setUsername] = useState('');
const [submitted, setSubmitted] = useState(false);
const handleSubmit = () => {
setSubmitted(true); // Just a flag, no actual logic
};
useEffect(() => {
if (submitted) {
login(username); // What triggered this? Which submit was it?
}
}, [submitted, username]);
}// ✅ GOOD: Clear intent, direct action
function LoginForm() {
const [username, setUsername] = useState('');
const handleSubmit = async (e) => {
e.preventDefault(); // User action context preserved
// Actual logic here, not delayed
try {
await login(username);
} catch (error) {
console.error('Login failed:', error);
}
};
return <form onSubmit={handleSubmit}>...</form>;
}// ❌ 不良写法:意图不清晰,难以追踪
function LoginForm() {
const [username, setUsername] = useState('');
const [submitted, setSubmitted] = useState(false);
const handleSubmit = () => {
setSubmitted(true); // 仅设置标记位,无实际逻辑
};
useEffect(() => {
if (submitted) {
login(username); // 是什么触发了这个操作?是哪次提交?
}
}, [submitted, username]);
}// ✅ 推荐写法:意图清晰,直接执行
function LoginForm() {
const [username, setUsername] = useState('');
const handleSubmit = async (e) => {
e.preventDefault(); // 保留用户操作上下文
// 实际逻辑直接在此执行,无延迟
try {
await login(username);
} catch (error) {
console.error('Login failed:', error);
}
};
return <form onSubmit={handleSubmit}>...</form>;
}// ❌ BAD: Unnecessary effect
function ProductList({ products }) {
const [visibleProducts, setVisibleProducts] = useState([]);
useEffect(() => {
setVisibleProducts(products.filter(p => p.inStock));
}, [products]); // Runs twice whenever products change
}// ✅ GOOD: Immediate, single render
function ProductList({ products }) {
const visibleProducts = products.filter(p => p.inStock);
}// ❌ 不良写法:不必要的effect
function ProductList({ products }) {
const [visibleProducts, setVisibleProducts] = useState([]);
useEffect(() => {
setVisibleProducts(products.filter(p => p.inStock));
}, [products]); // 每次products变化时执行两次
}// ✅ 推荐写法:即时执行,单次渲染
function ProductList({ products }) {
const visibleProducts = products.filter(p => p.inStock);
}useStateuseEffect// ❌ BAD: UI can show inconsistent state during concurrent updates
function WindowSize() {
const [width, setWidth] = useState(window.innerWidth);
useEffect(() => {
const handleResize = () => setWidth(window.innerWidth);
window.addEventListener('resize', handleResize);
return () => window.removeEventListener('resize', handleResize);
}, []);
}useSyncExternalStore// ✅ GOOD: Prevents tearing, single source of truth
function WindowSize() {
const width = useSyncExternalStore(
// Subscribe - return cleanup function
(callback) => {
window.addEventListener('resize', callback);
return () => window.removeEventListener('resize', callback);
},
// Get snapshot
() => window.innerWidth,
// Server fallback
() => 1200
);
}useStateuseEffect// ❌ 不良写法:并发更新期间UI可能显示不一致状态
function WindowSize() {
const [width, setWidth] = useState(window.innerWidth);
useEffect(() => {
const handleResize = () => setWidth(window.innerWidth);
window.addEventListener('resize', handleResize);
return () => window.removeEventListener('resize', handleResize);
}, []);
}useSyncExternalStore// ✅ 推荐写法:防止撕裂,单一数据源
function WindowSize() {
const width = useSyncExternalStore(
// 订阅 - 返回清理函数
(callback) => {
window.addEventListener('resize', callback);
return () => window.removeEventListener('resize', callback);
},
// 获取快照
() => window.innerWidth,
// 服务端回退值
() => 1200
);
}// ❌ BAD: Id never updates, always fetches user 1
function UserProfile({ userId }) {
const [user, setUser] = useState(null);
useEffect(() => {
fetch(`/user/1`).then(res => res.json()).then(setUser);
}, [ ]); // Missing userId dependency!
}// ✅ GOOD: Correct dependencies
function UserProfile({ userId }) {
const [user, setUser] = useState(null);
useEffect(() => {
fetch(`/user/${userId}`).then(res => res.json()).then(setUser);
}, [userId]); // Properly tracks changes
}// ✅ EVEN BETTER: No effect, just loader
function UserProfile({ userId }) {
const user = use(userId); // React 19's use API
// Or use React Query, SWR, etc.
}// ❌ 不良写法:Id从不更新,始终请求用户1的数据
function UserProfile({ userId }) {
const [user, setUser] = useState(null);
useEffect(() => {
fetch(`/user/1`).then(res => res.json()).then(setUser);
}, [ ]); // 缺少userId依赖!
}// ✅ 推荐写法:正确的依赖项
function UserProfile({ userId }) {
const [user, setUser] = useState(null);
useEffect(() => {
fetch(`/user/${userId}`).then(res => res.json()).then(setUser);
}, [userId]); // 正确追踪变化
}// ✅ 更优写法:无effect,仅使用loader
function UserProfile({ userId }) {
const user = use(userId); // React 19的use API
// 或使用React Query、SWR等库
}Need to sync with external system?
├─ Yes (browser APIs, websockets, timers)
│ └─ Use useEffect
│
└─ No (pure React application logic)
├─ Derived state calculation?
│ ├─ Yes → Calculate during render
│ └─ No → Continue...
│
├─ User action triggered?
│ ├─ Yes → Use event handler
│ └─ No → Continue...
│
├─ State reset needed?
│ ├─ Yes → Use key prop
│ └─ No → Continue...
│
└─ Really need effect after re-think?
└─ Yes → Use useState/useReducer/setState pattern是否需要与外部系统同步?
├─ 是(浏览器API、websocket、定时器)
│ └─ 使用useEffect
│
└─ 否(纯React应用逻辑)
├─ 是否为派生状态计算?
│ ├─ 是 → 在渲染阶段计算
│ └─ 否 → 继续...
│
├─ 是否由用户操作触发?
│ ├─ 是 → 使用事件处理器
│ └─ 否 → 继续...
│
├─ 是否需要重置状态?
│ ├─ 是 → 使用key prop
│ └─ 否 → 继续...
│
└─ 重新思考后是否真的需要effect?
└─ 是 → 使用useState/useReducer/setState模式// BAD
function Modal() {
useEffect(() => {
document.body.style.overflow = 'hidden';
return () => { document.body.style.overflow = ''; };
}, []);
}// 不良写法
function Modal() {
useEffect(() => {
document.body.style.overflow = 'hidden';
return () => { document.body.style.overflow = ''; };
}, []);
}// BAD
function App({ data }) {
useEffect(() => {
console.log('Data changed:', data);
}, [data]);
}React DevTools// 不良写法
function App({ data }) {
useEffect(() => {
console.log('Data changed:', data);
}, [data]);
}React DevTools// BAD
function Widget() {
const [initialized, setInitialized] = useState(false);
useEffect(() => {
someLibrary.init();
setInitialized(true);
}, []);
}// GOOD
let initialized = false;
function Widget() {
if (!initialized) {
someLibrary.init();
initialized = true;
}
}// 不良写法
function Widget() {
const [initialized, setInitialized] = useState(false);
useEffect(() => {
someLibrary.init();
setInitialized(true);
}, []);
}// 推荐写法
let initialized = false;
function Widget() {
if (!initialized) {
someLibrary.init();
initialized = true;
}
}| Scenario | Problem | Alternative |
|---|---|---|
| Derived state | Double render | Calculate during render |
| State resets | Stale data | Use |
| User actions | Lost intent | Event handlers |
| List filtering | Extra renders | Filter in render |
| Browser APIs | Tearing bugs (concurrent) | |
| Form submission | Fragile flag pattern | Direct async handler |
| Data fetching | Manual cache management | React Query, SWR, Suspense |
| 场景 | 问题 | 替代方案 |
|---|---|---|
| 派生状态 | 双重渲染 | 在渲染阶段计算 |
| 状态重置 | 数据过期 | 使用 |
| 用户操作 | 丢失意图 | 事件处理器 |
| 列表过滤 | 额外渲染 | 在渲染阶段过滤 |
| 浏览器API | 并发撕裂bug | |
| 表单提交 | 脆弱的标记位模式 | 直接异步处理器 |
| 数据请求 | 手动缓存管理 | React Query、SWR、Suspense |
use// React 19+ - Direct resource reading
function UserProfile({ userId }) {
const user = use(fetchUser(userId)); // Reads promise directly
return <div>{user.name}</div>;
}use// React 19+ - 直接读取资源
function UserProfile({ userId }) {
const user = use(fetchUser(userId)); // 直接读取Promise
return <div>{user.name}</div>;
}