workbench-code-review

Compare original and translation side by side

🇺🇸

Original

English
🇨🇳

Translation

Chinese

Workbench Code Review

Workbench Code Review

Use this skill for reviewing code, diffs, task plans, live workflow changes, and implementation evidence before merge or closure.
使用此skill对代码、代码差异、任务计划、实时工作流变更及实现证据进行评审,适用于合并或关闭前的环节。

Review Stance

评审原则

  • Findings first. Do not lead with praise or a broad summary.
  • Order findings by severity and user impact.
  • Tie every finding to a file, command, issue/comment ID, run ID, or observable behavior.
  • Prefer concrete repro or blast-radius evidence over style opinions.
  • If no issues are found, say that clearly and name remaining test gaps.
  • 优先呈现问题。不要以表扬或宽泛总结开头。
  • 按严重程度和用户影响排序问题。
  • 每个问题都需关联到具体文件、命令、问题/评论ID、运行ID或可观察行为。
  • 优先提供可复现的具体证据或影响范围证据,而非风格层面的意见。
  • 若未发现问题,需明确说明,并指出剩余的测试缺口。

Severity

严重等级

  • P0
    : security, data loss, irreversible action, or broken primary workflow.
  • P1
    : likely user-facing regression or unsafe automation.
  • P2
    : correctness gap, missing edge case, or weak verification.
  • P3
    : maintainability, clarity, or low-risk cleanup.
  • P0
    :安全问题、数据丢失、不可逆操作或核心工作流故障。
  • P1
    :可能影响用户的回归问题或不安全的自动化操作。
  • P2
    :正确性缺陷、遗漏的边缘场景或验证不足。
  • P3
    :可维护性、清晰度问题或低风险的清理工作。

Checklist

检查清单

  • Does the implementation match the promised objective?
  • Are owner boundaries preserved?
  • Are live mutations backed up and reversible?
  • Are commands, IDs, and paths reproducible?
  • Are tests or real-path checks sufficient for the blast radius?
  • Did the change avoid unrelated refactors and hidden policy changes?
  • 实现是否符合预期目标?
  • 是否保留了职责边界?
  • 实时变更是否有备份且可回滚?
  • 命令、ID和路径是否可复现?
  • 测试或实际路径检查是否足以覆盖影响范围?
  • 变更是否避免了无关的重构和隐藏的策略变更?

Output Contract

输出规范

For findings:
  • SEVERITY
  • LOCATION
  • ISSUE
  • WHY IT MATTERS
  • REQUIRED FIX
For a clean review:
  • VERDICT: PASS
  • EVIDENCE CHECKED
  • TEST GAPS
  • RESIDUAL RISK
若发现问题:
  • SEVERITY
    (严重等级)
  • LOCATION
    (位置)
  • ISSUE
    (问题)
  • WHY IT MATTERS
    (影响原因)
  • REQUIRED FIX
    (修复要求)
若评审通过:
  • VERDICT: PASS
    (结论:通过)
  • EVIDENCE CHECKED
    (已检查的证据)
  • TEST GAPS
    (测试缺口)
  • RESIDUAL RISK
    (剩余风险)