Loading...
Loading...
Use when executing implementation plans with independent tasks in the current session - dispatches fresh subagent for each task, reviews once per phase, loads phases just-in-time to minimize context usage
npx skill4agent add ed3dai/ed3d-plugins executing-an-implementation-planrequesting-code-reviewQuestion: "Which implementation plan should I execute?"
Options:
- [list any plan directories you find in docs/implementation-plans/]
- "Let me provide the path"docs/implementation-plans/# List phase files
ls [plan-directory]/phase_*.md
# For each file, get the header (first 10 lines include title and Goal)
head -10 [plan-directory]/phase_01.md
# Get task/subcomponent structure without reading full content
grep -E "START_TASK_|START_SUBCOMPONENT_" [plan-directory]/phase_01.md# [Phase Title]**Goal:**<!-- START_TASK_1 -->
<!-- START_TASK_2 -->
<!-- START_SUBCOMPONENT_A (tasks 3-5) -->
<!-- START_TASK_3 -->
<!-- START_TASK_4 -->
<!-- START_TASK_5 --># Document Infrastructure Implementation Plan# Phase 4: Link Resolution.ed3d/implementation-plan-guidance.md# Check for implementation guidance (note the absolute path for later use)
ls [project-root]/.ed3d/implementation-plan-guidance.mdtest-requirements.md# Check for test requirements (note the absolute path for later use)
ls [plan-directory]/test-requirements.md- [ ] Phase 1a: Read /absolute/path/to/phase_01.md — Document Infrastructure Implementation Plan
- [ ] Phase 1b: Execute tasks
- [ ] Phase 1c: Code review
- [ ] Phase 2a: Read /absolute/path/to/phase_02.md — API Integration
- [ ] Phase 2b: Execute tasks
- [ ] Phase 2c: Code review
...task-implementor-fast<invoke name="Task">
<parameter name="subagent_type">ed3d-plan-and-execute:task-implementor-fast</parameter>
<parameter name="description">Implementing Phase X, Task Y: [description]</parameter>
<parameter name="prompt">
Implement Task N from the phase file.
Phase file: [absolute path to phase file]
Task number: N
Read the phase file and implement Task N (look for `<!-- START_TASK_N -->`).
Your job is to:
1. Read the phase file to understand context
2. Apply all relevant skills, such as (if available) ed3d-house-style:coding-effectively
3. Implement exactly what Task N specifies
4. Verify with tests/build/lint
5. Commit your work
6. Report back with evidence
Work from: [directory]
Provide complete report per your agent instructions.
</parameter>
</invoke><invoke name="Task">
<parameter name="subagent_type">ed3d-plan-and-execute:task-implementor-fast</parameter>
<parameter name="description">Implementing Phase X, Subcomponent A (Tasks 3-5): [description]</parameter>
<parameter name="prompt">
Implement Subcomponent A (Tasks 3, 4, 5) from the phase file.
Phase file: [absolute path to phase file]
Tasks: 3, 4, 5 (look for `<!-- START_SUBCOMPONENT_A -->`)
Read the phase file and implement all tasks in this subcomponent.
Your job is to:
1. Read the phase file to understand context
2. Apply all relevant skills, such as (if available) ed3d-house-style:coding-effectively
3. Implement all tasks in sequence
4. Verify with tests/build/lint after completing all tasks
5. Commit your work (one commit per task, or logical commits)
6. Report back with evidence for each task
Work from: [directory]
Provide complete report covering all tasks.
</parameter>
</invoke>requesting-code-review.ed3d/implementation-plan-guidance.mdTaskCreate: "Phase N fix [Critical]: <VERBATIM issue description from reviewer>"
TaskCreate: "Phase N fix [Important]: <VERBATIM issue description from reviewer>"
TaskCreate: "Phase N fix [Minor]: <VERBATIM issue description from reviewer>"
...one task per issue...
TaskCreate: "Phase N: Re-review after fixes"
TaskUpdate: set "Re-review" blocked by all fix taskstask-bug-fixer<invoke name="Task">
<parameter name="subagent_type">ed3d-plan-and-execute:task-bug-fixer</parameter>
<parameter name="description">Fixing review issues for Phase X</parameter>
<parameter name="prompt">
Fix issues from code review for Phase X.
Phase file: [absolute path to phase file]
Code reviewer found these issues:
[list all issues - Critical, Important, and Minor]
Read the phase file to understand the tasks and context.
Your job is to:
1. Understand root cause of each issue
2. Apply fixes systematically (Critical → Important → Minor)
3. Verify with tests/build/lint
4. Commit your fixes
5. Report back with evidence
Work from: [directory]
Fix ALL issues — including every Minor issue. The goal is ZERO issues on re-review.
Minor issues are not optional. Do not skip them.
</parameter>
</invoke>requesting-code-reviewed3d-extending-claude:project-claude-librarian<invoke name="Task">
<parameter name="subagent_type">ed3d-extending-claude:project-claude-librarian</parameter>
<parameter name="description">Updating project context after implementation</parameter>
<parameter name="prompt">
Review what changed during this implementation and update CLAUDE.md files if contracts or structure changed.
Base commit: <commit SHA at start of first phase>
Current HEAD: <current commit>
Working directory: <directory>
Follow the ed3d-extending-claude:maintaining-project-context skill to:
1. Diff against base to see what changed
2. Identify contract/API/structure changes
3. Update affected CLAUDE.md files
4. Commit documentation updates
Report back with what was updated (or that no updates were needed).
</parameter>
</invoke>ed3d-extending-claudeCode Review → Test Analysis (Coverage + Plan)requesting-code-review{slug}.AC*<invoke name="Task">
<parameter name="subagent_type">ed3d-plan-and-execute:test-analyst</parameter>
<parameter name="description">Analyzing test coverage and generating test plan</parameter>
<parameter name="prompt">
Analyze test implementation against acceptance criteria.
TEST_REQUIREMENTS_PATH: [absolute path to test-requirements.md]
WORKING_DIRECTORY: [project root]
BASE_SHA: [commit before first phase]
HEAD_SHA: [current commit]
Phase 1: Validate that automated tests exist for all acceptance criteria.
Phase 2: If coverage passes, generate human test plan using your analysis.
Return coverage validation result. If PASS, include the human test plan.
</parameter>
</invoke><invoke name="Task">
<parameter name="subagent_type">ed3d-plan-and-execute:task-bug-fixer</parameter>
<parameter name="description">Adding missing test coverage</parameter>
<parameter name="prompt">
Add missing tests identified by the test analyst.
Missing coverage:
[list from analyst output]
For each missing test:
1. Read the acceptance criterion carefully
2. Create the test file at the expected location
3. Write tests that verify the criterion's actual behavior—not just code that passes, but code that would fail if the criterion weren't met
4. Run tests to confirm they pass
5. Commit the new tests
Work from: [directory]
</parameter>
</invoke># Create test-plans directory if needed
mkdir -p docs/test-plans
# The filename uses the implementation plan directory name
# e.g., impl plan dir: docs/implementation-plans/2025-01-24-oauth/
# test plan: docs/test-plans/2025-01-24-oauth.mddocs/test-plans/[impl-plan-dir-name].mdgit add docs/test-plans/[impl-plan-dir-name].md
git commit -m "docs: add test plan for [feature name]"docs/test-plans/[impl-plan-dir-name].mdfinishing-a-development-branchYou: I'm using the `executing-an-implementation-plan` skill.
[Discover phases: phase_01.md, phase_02.md, phase_03.md]
[Read first 3 lines of each to get titles]
[Create tasks with TaskCreate:]
- [ ] Phase 1a: Read /path/to/phase_01.md — Project Setup
- [ ] Phase 1b: Execute tasks
- [ ] Phase 1c: Code review
- [ ] Phase 2a: Read /path/to/phase_02.md — Token Service
- [ ] Phase 2b: Execute tasks
- [ ] Phase 2c: Code review
- [ ] Phase 3a: Read /path/to/phase_03.md — API Middleware
- [ ] Phase 3b: Execute tasks
- [ ] Phase 3c: Code review
--- Phase 1 ---
[Mark 1a in_progress, read phase_01.md]
→ Contains 2 tasks: project setup, config files
[Mark 1a complete, 1b in_progress]
[Dispatch task-implementor-fast for Task 1]
→ Created package.json, tsconfig.json.
[Dispatch task-implementor-fast for Task 2]
→ Created config files. Build succeeds.
[Mark 1b complete, 1c in_progress]
[Use requesting-code-review skill for phase 1]
→ Zero issues.
[Mark 1c complete]
--- Phase 2 ---
[Mark 2a in_progress, read phase_02.md]
→ Contains 3 tasks: types, service, tests
[Mark 2a complete, 2b in_progress]
[Execute all 3 tasks...]
[Mark 2b complete, 2c in_progress]
[Use requesting-code-review skill for phase 2]
→ Important: 1, Minor: 1
→ Dispatch bug-fixer, re-review
→ Zero issues.
[Mark 2c complete]
--- Phase 3 ---
[Similar pattern...]
--- Finalize ---
[Invoke project-claude-librarian subagent]
→ Updated CLAUDE.md.
[Use requesting-code-review skill for final review]
→ All requirements met.
[Transitioning to finishing-a-development-branch]| Excuse | Reality |
|---|---|
| "I'll read all phases upfront to understand the full picture" | No. Read one phase at a time. Context limits are real. |
| "I'll skip the read step, I remember what's in the file" | No. Always read just-in-time. Context may have been compacted. |
| "I'll review after each task to catch issues early" | No. Review once per phase. Task-level review wastes context. |
| "Context error on review, I'll skip the review" | No. Chunk the review into halves. Never skip review. |
| "Minor issues can wait" | No. Fix ALL issues including Minor. |