Skill Variant: Use this skill for autonomous, comprehensive code reviews with structured checklists. For interactive code review discussions with user feedback, use
code-review
instead.

技能变体： 本技能用于基于结构化检查清单开展自治的全方面代码评审。若需要用户反馈参与的交互式代码评审讨论，请使用
code-review
技能。

Code Review Workflow

代码评审工作流

Summary

摘要

Goal: Perform autonomous, comprehensive code reviews with structured checklists covering architecture, patterns, quality, security, and performance.

Step	Action	Key Notes
1	Understand context	Read changed files, identify scope and intent
2	Architecture compliance	Clean Architecture layers, repository patterns, service boundaries
3	Pattern adherence	CQRS, entity patterns, component hierarchy, platform base classes
4	Code quality	SRP, DRY, naming, abstractions
5	Security & performance	Authorization, injection, N+1, pagination, caching
6	Generate report	Findings with severity, file references, suggested fixes

Key Principles:

Autonomous variant — for interactive reviews with user feedback, use
```
code-review
```
instead
Check all 5 review dimensions: architecture, patterns, quality, security, performance
Every finding must reference specific file and line

目标： 基于覆盖架构、代码模式、质量、安全与性能的结构化检查清单，开展自治的全方面代码评审。

步骤	操作	关键说明
1	理解上下文	读取变更文件，明确评审范围与意图
2	架构合规性	符合Clean Architecture分层、仓库模式、服务边界要求
3	模式遵循度	CQRS、实体模式、组件层级、平台基类使用规范
4	代码质量	SRP、DRY原则、命名规范、抽象合理性
5	安全与性能	授权机制、注入漏洞、N+1查询问题、分页、缓存
6	生成报告	带严重等级的问题发现、文件引用、修复建议

核心原则：

自治变体——如需用户反馈的交互式评审，请使用
```
code-review
```
技能
覆盖全部5个评审维度：架构、模式、质量、安全、性能
每个问题发现必须关联具体文件和行号

When to Use This Skill

何时使用本技能

Reviewing pull requests
Analyzing code for refactoring
Pre-commit code quality check
Security and performance audit

评审拉取请求（PR）
待重构代码分析
代码提交前质量检查
安全与性能审计

Review Dimensions

评审维度

1. Architecture Compliance

1. 架构合规性

Follows Clean Architecture layers
Uses correct repository pattern
No cross-service boundary violations
Proper separation of concerns

遵循Clean Architecture分层要求
正确使用仓库模式
无跨服务边界违规情况
合理的关注点分离

2. Pattern Adherence

2. 模式遵循度

CQRS patterns followed (Command/Query/Handler in ONE file)
Entity patterns correct (expressions, computed properties)
Frontend component hierarchy respected
Platform base classes used correctly

符合CQRS模式要求（命令/查询/处理器放在同一个文件中）
实体模式正确（表达式、计算属性）
遵守前端组件层级规范
正确使用平台基类

3. Code Quality

3. 代码质量

Single Responsibility Principle
No code duplication
Meaningful naming
Appropriate abstractions

符合单一职责原则（SRP）
无代码重复
命名语义化
抽象层级合理

4. Security

4. 安全

No SQL injection vulnerabilities
Authorization checks present
Sensitive data handling
Input validation

无SQL注入漏洞
存在完善的授权检查
敏感数据处理合规
输入校验覆盖全面

5. Performance

5. 性能

N+1 query prevention (eager loading)
Proper paging for large datasets
Parallel operations where applicable
Caching considerations

预防N+1查询（使用预加载）
大数据集配置合理分页
合适场景下使用并行操作
考虑缓存策略适配

Review Process

评审流程

Step 1: Understand Context

步骤1：理解上下文

bash

undefined

bash

undefined

Get changed files

git diff --name-only main...HEAD

Get full diff

git diff main...HEAD

Check commit messages

git log main...HEAD --oneline

undefined

git log main...HEAD --oneline

undefined

Step 2: Categorize Changes

步骤2：变更归类

markdown

undefined

markdown

undefined

Files Changed

Domain Layer

```
Entity.cs
```
- New entity

```
Entity.cs
```
- New entity

Application Layer

```
SaveEntityCommand.cs
```
- New command

```
SaveEntityCommand.cs
```
- New command

Persistence Layer

```
EntityConfiguration.cs
```
- EF configuration

```
EntityConfiguration.cs
```
- EF configuration

Frontend

```
entity-list.component.ts
```
- List component

undefined

```
entity-list.component.ts
```
- List component

undefined

Step 3: Review Each Category

步骤3：分类评审

Backend Review Checklist

后端评审检查清单

markdown

undefined

markdown

undefined

Entity Review

Inherits from correct base (RootEntity/RootAuditedEntity)
Static expressions for queries
Computed properties have empty
```
set { }
```
Navigation properties have
```
[JsonIgnore]
```
```
[TrackFieldUpdatedDomainEvent]
```
on tracked fields

Inherits from correct base (RootEntity/RootAuditedEntity)
Static expressions for queries
Computed properties have empty
```
set { }
```
Navigation properties have
```
[JsonIgnore]
```
```
[TrackFieldUpdatedDomainEvent]
```
on tracked fields

Command/Query Review

Command + Handler + Result in ONE file
Uses service-specific repository
Validation uses fluent API
No side effects in command handler
DTO mapping in DTO class, not handler

Command + Handler + Result in ONE file
Uses service-specific repository
Validation uses fluent API
No side effects in command handler
DTO mapping in DTO class, not handler

Repository Usage Review

Uses
```
GetQueryBuilder
```
for reusable queries
Uses
```
WhereIf
```
for optional filters
Parallel tuple queries for count + data
Proper eager loading

Uses
```
GetQueryBuilder
```
for reusable queries
Uses
```
WhereIf
```
for optional filters
Parallel tuple queries for count + data
Proper eager loading

Event Handler Review

In
```
UseCaseEvents/
```
folder

Uses

PlatformCqrsEntityEventApplicationHandler<T>

HandleWhen

is

public override async Task<bool>

Filters by
```
CrudAction
```
appropriately

undefined

In
```
UseCaseEvents/
```
folder

Uses

PlatformCqrsEntityEventApplicationHandler<T>

HandleWhen

is

public override async Task<bool>

Filters by
```
CrudAction
```
appropriately

undefined

Frontend Review Checklist

前端评审检查清单

markdown

undefined

markdown

undefined

Component Review

Correct base class for use case
Store provided at component level
Loading/error states handled
```
untilDestroyed()
```
on subscriptions
Track-by in
```
@for
```
loops

Correct base class for use case
Store provided at component level
Loading/error states handled
```
untilDestroyed()
```
on subscriptions
Track-by in
```
@for
```
loops

Store Review

State interface defined
```
vmConstructor
```
provides defaults
Effects use
```
observerLoadingErrorState
```
Immutable state updates

State interface defined
```
vmConstructor
```
provides defaults
Effects use
```
observerLoadingErrorState
```
Immutable state updates

Form Review

```
validateForm()
```
before submit
Async validators conditional
Dependent validations configured
Error messages for all rules

```
validateForm()
```
before submit
Async validators conditional
Dependent validations configured
Error messages for all rules

API Service Review

Extends
```
PlatformApiService
```
Typed responses
Caching where appropriate

undefined

Extends
```
PlatformApiService
```
Typed responses
Caching where appropriate

undefined

Step 4: Security Review

步骤4：安全评审

markdown

undefined

markdown

undefined

Security Checklist

Authorization

```
[PlatformAuthorize]
```
on controllers
Role checks in handlers
Data filtered by company/user context

```
[PlatformAuthorize]
```
on controllers
Role checks in handlers
Data filtered by company/user context

Input Validation

All inputs validated
No raw SQL strings
File upload validation

All inputs validated
No raw SQL strings
File upload validation

Sensitive Data

No secrets in code
Passwords hashed
PII handled correctly

undefined

No secrets in code
Passwords hashed
PII handled correctly

undefined

Step 5: Performance Review

步骤5：性能评审

markdown

undefined

markdown

undefined

Performance Checklist

Database

Indexes on filtered columns
Eager loading for N+1 prevention
Paging for large datasets

Indexes on filtered columns
Eager loading for N+1 prevention
Paging for large datasets

API

Response size reasonable
Parallel operations used
Caching for static data

Response size reasonable
Parallel operations used
Caching for static data

Frontend

Lazy loading for routes
Track-by for lists
OnPush change detection

undefined

Lazy loading for routes
Track-by for lists
OnPush change detection

undefined

Review Report Template

评审报告模板

markdown

undefined

markdown

undefined

Code Review Report

Summary

PR/Changes: [Description]
Reviewer: AI
Date: [Date]

PR/Changes: [Description]
Reviewer: AI
Date: [Date]

Overall Assessment

[APPROVED | APPROVED WITH COMMENTS | CHANGES REQUESTED]

Issues Found

Critical (Must Fix)

[File:Line]: [Description]

[File:Line]: [Description]

Major (Should Fix)

[File:Line]: [Description]

[File:Line]: [Description]

Minor (Consider Fixing)

[File:Line]: [Description]

[File:Line]: [Description]

Recommendations

[Recommendation 1]
[Recommendation 2]

undefined

[Recommendation 1]
[Recommendation 2]

undefined

tasks-code-review

Original

Translation

Code Review Workflow

代码评审工作流

Summary

摘要

When to Use This Skill

何时使用本技能

Review Dimensions

评审维度

1. Architecture Compliance

1. 架构合规性

2. Pattern Adherence

2. 模式遵循度

3. Code Quality

3. 代码质量

4. Security

4. 安全

5. Performance

5. 性能

Review Process

评审流程

Step 1: Understand Context

步骤1：理解上下文

Get changed files

Get changed files

Get full diff

Get full diff

Check commit messages

Check commit messages

Step 2: Categorize Changes

步骤2：变更归类

Files Changed

Files Changed

Domain Layer

Domain Layer

Application Layer

Application Layer

Persistence Layer

Persistence Layer

Frontend

Frontend

Step 3: Review Each Category

步骤3：分类评审

Backend Review Checklist

后端评审检查清单

Entity Review

Entity Review

Command/Query Review

Command/Query Review

Repository Usage Review

Repository Usage Review

Event Handler Review

Event Handler Review

Frontend Review Checklist

前端评审检查清单

Component Review

Component Review

Store Review

Store Review

Form Review

Form Review

API Service Review

API Service Review

Step 4: Security Review

步骤4：安全评审

Security Checklist

Security Checklist

Authorization

Authorization

Input Validation

Input Validation

Sensitive Data

Sensitive Data

Step 5: Performance Review

步骤5：性能评审

Performance Checklist

Performance Checklist

Database