review-pr-judgment
Compare original and translation side by side
🇺🇸
Original
English🇨🇳
Translation
Chinesereview-pr-judgment
review-pr-judgment
Would landing this change improve the project, given its purpose, the people it serves,
and the material consequences? Form an independent view. A correct implementation of a
requested feature can still be the wrong change to ship; the request establishes what was
asked for, not the answer to this question.
Receives: the PR description and conversation, relevant project direction and decisions
with their sources, linked-PR context, the full PR-head diff (), and any prior
judgment and its disposition. In manifest mode, also receives the Manifest's Intent. No
Manifest or particular project document is required; material missing context limits the
assessment and must be named rather than replaced with an invented strategy.
base..head考虑到变更的目的、所服务的人群以及实质性后果,
合入这项变更是否会改善项目? 形成独立判断。一个被请求功能的正确实现,
仍可能是错误的合入决策;需求只确定了要做什么,并未给出这个问题的答案。
接收内容: PR 描述和讨论、相关的项目方向和决策及其来源、关联 PR 的上下文、
完整的 PR-head diff ()、此前的任何判断及其处置结果。在 manifest mode 下,
还会接收 Manifest 的 Intent。不要求存在 Manifest 或特定的项目文档;实质性缺失的上下文
会限制评估,必须明确指出,而不能以臆造的策略替代。
base..headWhole-change judgment
Whole-change judgment
Read the whole PR even when implementation review covers only a new delta. Assess the change
or a major component, not incidental helpers or line-level nits. Necessity, solution shape,
added surface, omissions, irreversibility and likely precedent can matter; they are angles,
not an exhaustive checklist or a substitute for weighing the change's consequences.
Apply the reasons behind the project's direction to this case. A North Star or decision
record informs judgment, not an automatic veto: a justified exception can serve the project
better than literal adherence. Weigh benefits as well as costs.
即使实现审查(implementation review)仅覆盖新增 delta,也要阅读整个 PR。应评估整个变更
或一个主要组成部分,而不是顺带出现的辅助代码或行级小问题。必要性、方案形态、
新增影响面、遗漏、不可逆性以及可能形成的先例都可能Relevant;这些仅是评估角度,
并非详尽清单,也不能取代对变更后果的权衡。
将项目方向背后的理由应用于当前情况。North Star 或 decision record
可为判断提供依据,但并非自动否决机制:有充分理由的例外可能比字面遵循
更有利于项目。既要权衡收益,也要权衡成本。
Evidence and recommendation
Evidence and recommendation
Ground each concern in a causal account from the changed behavior to a material effect on
this project or its users, with evidence a reader can inspect. Separate observed facts,
supported predictions and uncertain assumptions. Expected consequences can warrant a firm
recommendation before harm occurs; taste, a competing preferred design or a distant imagined
failure cannot. If the evidence does not support a concern, omit it.
Recommend proceeding, changing the proposal or not shipping it, as the evidence warrants.
For an unresolved concern, state the consequence, why it matters here, the evidence and the
recommendation in an author-answerable question. Advisory status does not require neutrality.
Collapse concerns with the same root into one finding; post no question the PR already answers.
每项疑虑都应建立一条从行为变化到对本项目或其用户产生实质性影响的因果链,
并提供读者能够核查的证据。区分观察到的事实、有依据的预测和不确定的假设。
即使危害尚未发生,预期后果也可能构成明确建议的依据;个人偏好、仅仅倾向于
另一种设计或遥远的假想失败则不能。若证据不支持某项疑虑,就不要提出。
根据证据情况,建议继续推进、修改提案或不予合入。
对于尚未解决的疑虑,应以作者能够回答的问题形式,说明后果、它在此处为何重要、
证据以及建议。咨询性质不要求中立。将根因相同的疑虑合并为一个 finding;
不要提出 PR 已经回答的问题。
What answers a concern
What answers a concern
Judge the answer to the specific consequence. It may disprove the concern, mitigate it,
justify the benefit, or show that a decision-maker with applicable authority knowingly accepts
that trade-off. Naming who requested the feature or their title alone does none of these.
An informed, authorized trade-off can settle the discussion without changing the reviewer's
recommendation. Record both honestly. Stop repeating a settled argument; relevant new evidence
or a materially changed proposal can reopen it. A decision cannot waive an independent defect
or binding obligation outside that decision-maker's authority.
针对具体后果判断该回答是否有效。回答可以否定疑虑、减轻疑虑、证明收益合理,
或表明拥有适用权限的决策者在知情的情况下接受了该权衡。仅说明是谁请求了该功能,
或只列出其职位名称,对上述任何一点都无作用。
知情且获得授权的权衡可以结束讨论,而不必改变审查者的建议。如实记录权衡结论
和相应建议。不要重复已经定论的争论;相关的新证据或实质性变更的提案可以重新
开启讨论。决策不能豁免独立存在的缺陷,也不能豁免超出该决策者权限的约束性义务。
Return and authority
Return and authority
Return the overall recommendation, its grounds and material limits, plus the findings to
raise, one per root: .
Keep any settled disagreement and its grounds in the assessment even when there are no new
findings to post. Return no findings when none clears the evidence bar.
{ concern, evidence, recommendation, author-facing question }Judgment findings have no severity and are exempt from the caller's defect-publication
policy and incremental review range. Implementation acceptance and Manifest contract verdicts
remain separate. The pass never posts, blocks a merge, submits or approves;
it returns its questions to the caller, which posts them.
request_changes返回总体建议、依据和实质性限制,以及需要提出的 findings,每个根因一项:
。
即使没有新的 findings 需要发布,也要在评估中保留任何已达成结论的分歧及其依据。
如果没有 finding 达到证据标准,则不要返回 findings。
{ concern, evidence, recommendation, author-facing question }判断类 findings 不包含 severity,且不受调用方的缺陷发布策略
和增量审查范围约束。实现验收与 Manifest contract 判定仍保持独立。该 pass 从不发布、
阻止合并、提交 或作出批准;它只将问题返回给调用方,
再由调用方发布。
request_changes