Back to Details

review-and-ship

Compare original and translation side by side

🇺🇸

Original

English
🇨🇳

Translation

Chinese

Review and ship

审查与交付

Trigger

触发时机

Reviewing changes before shipping. Close key issues, verify behavior, and open or update a PR.
在交付前审查变更。解决关键问题，验证行为，创建或更新PR。

Workflow

工作流程

  1. Gather context: diff against base branch, uncommitted changes, recent commits, changed files, and user intent from recent relevant chats if useful.
  2. Run targeted tests for changed behavior. If no focused tests exist, decide whether to add them or document the gap.
  3. Review for correctness, regressions, security, and intent fit. Use parallel subagents for larger diffs.
  4. Fix critical issues before finalizing and re-run affected tests.
  5. Commit selective files with a concise message.
  6. Push branch and open or update a PR.
  1. 收集上下文：与基准分支对比差异、未提交的变更、近期提交记录、修改的文件，如有需要可从近期相关对话中获取用户意图。
  2. 针对变更的行为运行定向测试。如果没有针对性测试，决定是添加测试还是记录该缺口。
  3. 审查正确性、回归问题、安全性以及意图匹配度。对于较大的差异，使用并行子Agent处理。
  4. 在最终确定前修复关键问题，并重新运行受影响的测试。
  5. 提交选定的文件并附上简洁的提交信息。
  6. 推送分支并创建或更新PR。

Suggested Checks

建议检查项

bash
git fetch origin main
git diff origin/main...HEAD
git status
gh pr checks --json name,bucket,state,workflow,link
bash
git fetch origin main
git diff origin/main...HEAD
git status
gh pr checks --json name,bucket,state,workflow,link

Guardrails

约束规则

  • Prioritize correctness, security, and regressions over style-only comments.
  • Keep commits focused and avoid unrelated file changes.
  • If pre-commit checks fail, fix the issues rather than bypassing hooks.
  • Use 
    gh pr checks
    instead of GitHub Actions-only commands when judging PR readiness.
  • 优先考虑正确性、安全性和回归问题，而非仅针对风格的评论。
  • 保持提交内容聚焦，避免无关文件变更。
  • 如果预提交检查失败，修复问题而非绕过钩子。
  • 判断PR是否就绪时，使用
    gh pr checks
    而非仅GitHub Actions专属命令。

Output

输出

  • Findings summary (critical, warning, note)
  • Tests run and outcomes
  • PR URL
  • 发现结果摘要（严重、警告、提示）
  • 已运行的测试及结果
  • PR 链接